Skip to content

Update BasicCallStack Test Frame lines for CppVsDbg #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WardenGnaw merged 2 commits into from
Jan 28, 2026
+15 −37
Merged

Update BasicCallStack Test Frame lines for CppVsDbg #1541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7fa847
Update BasicCallStack Test Frame lines
WardenGnaw Jan 27, 2026
d6b944f
x86 and x64 should be the same now
WardenGnaw Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 15 additions & 37 deletions test/CppTests/Tests/ExpressionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,43 +523,21 @@ private static StackFrame[] GenerateFramesList(IDebuggerSettings debugger)
// VsDbg moves the stack pointer to the return address which is not necessarily the calling address
if (debugger.DebuggerType == SupportedDebugger.VsDbg)
{
// Visual C++ compiler for x64 and x86 generate symbols differently which means that the line numbers will be different.
if (debugger.DebuggeeArchitecture == SupportedArchitecture.x64)
{
return new[] {
new StackFrame(10, "accumulate(", "expression.cpp", null),
new StackFrame(12, "accumulate(", "expression.cpp", null),
new StackFrame(12, "accumulate(", "expression.cpp", null),
new StackFrame(20, "func(", "expression.cpp", null),
new StackFrame(81, "Expression::checkCallStack(", "expression.cpp", null),
new StackFrame(74, "Expression::checkPrettyPrinting(", "expression.cpp", null),
new StackFrame(63, "Expression::checkSpecialValues(", "expression.cpp", null),
new StackFrame(53, "Expression::checkClassOnStackAndHeap(", "expression.cpp", null),
new StackFrame(40, "Expression::checkArrayAndPointers(", "expression.cpp", null),
new StackFrame(32, "Expression::checkPrimitiveTypes(", "expression.cpp", null),
new StackFrame(86, "Expression::CoreRun(", "expression.cpp", null),
new StackFrame(23, "Feature::Run(", "feature.cpp", null),
new StackFrame(45, "main", "main.cpp", null)
};
}
else
{
return new[] {
new StackFrame(10, "accumulate(", "expression.cpp", null),
new StackFrame(12, "accumulate(", "expression.cpp", null),
new StackFrame(12, "accumulate(", "expression.cpp", null),
new StackFrame(19, "func(", "expression.cpp", null),
new StackFrame(81, "Expression::checkCallStack(", "expression.cpp", null),
new StackFrame(75, "Expression::checkPrettyPrinting(", "expression.cpp", null),
new StackFrame(63, "Expression::checkSpecialValues(", "expression.cpp", null),
new StackFrame(54, "Expression::checkClassOnStackAndHeap(", "expression.cpp", null),
new StackFrame(40, "Expression::checkArrayAndPointers(", "expression.cpp", null),
new StackFrame(32, "Expression::checkPrimitiveTypes(", "expression.cpp", null),
new StackFrame(86, "Expression::CoreRun(", "expression.cpp", null),
new StackFrame(23, "Feature::Run(", "feature.cpp", null),
new StackFrame(46, "main", "main.cpp", null)
};
}
return new[] {
new StackFrame(10, "accumulate(", "expression.cpp", null),
new StackFrame(12, "accumulate(", "expression.cpp", null),
new StackFrame(12, "accumulate(", "expression.cpp", null),
new StackFrame(19, "func(", "expression.cpp", null),
new StackFrame(80, "Expression::checkCallStack(", "expression.cpp", null),
new StackFrame(74, "Expression::checkPrettyPrinting(", "expression.cpp", null),
new StackFrame(62, "Expression::checkSpecialValues(", "expression.cpp", null),
new StackFrame(53, "Expression::checkClassOnStackAndHeap(", "expression.cpp", null),
new StackFrame(39, "Expression::checkArrayAndPointers(", "expression.cpp", null),
new StackFrame(31, "Expression::checkPrimitiveTypes(", "expression.cpp", null),
new StackFrame(85, "Expression::CoreRun(", "expression.cpp", null),
new StackFrame(22, "Feature::Run(", "feature.cpp", null),
new StackFrame(45, "main", "main.cpp", null)
};
}
else
{
Expand Down
Loading