Streamline authentication methods #241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR streamlines all authentication methods across the workloads that don't have a dedicated PowerShell Module. It also fixes a couple of typos and introduces an improved change detection mechanism for parameters.
Previously, it was possible to connect to e.g. MicrosoftGraph with CertificateThumbprint. If you then tried to connect using Credentials, it would not reconnect because all of the authentication parameters for CertificateThumbprint were still set, resulting in the detection of the updated parameters to only count the ones responsible for CertificateThumbprint and ignore all others for Credentials.
The new logic first compares the different authentication methods (e.g. Credentials vs CertificateThumbprint) and only if they do match, it will compare the parameters that only apply to the matching authentication method. If there is already a difference in the authentication method, a reconnection is enforced.
This was tested with
-EnableSearchOnlySessionand other parameters, and verified with updated service principals as well as switching between Credentials and CertificateThumbprint.The streamlined workflows were tested again and updated where necessary. New authentication methods were introduced.
This change is