Check if predicate contains scope reference#2863
Open
anderson-joyle wants to merge 13 commits intomainfrom
Open
Check if predicate contains scope reference#2863anderson-joyle wants to merge 13 commits intomainfrom
anderson-joyle wants to merge 13 commits intomainfrom
Conversation
anderson-joyle
force-pushed
the
andersonf/2795-predicate-warning
branch
from
cd436ac to
9ce9887
Compare
anderson-joyle
commented
Mar 10, 2025
anderson-joyle
commented
Mar 10, 2025
src/libraries/Microsoft.PowerFx.Core/Functions/FunctionScopeInfo.cs
Outdated
Show resolved
Hide resolved
anderson-joyle
commented
Mar 10, 2025
Contributor
|
✅ No public API change. #Resolved |
anderson-joyle
commented
Mar 12, 2025
...s/Microsoft.PowerFx.Core.Tests.Shared/AssociatedDataSourcesTests/TestDelegationValidation.cs
Outdated
Show resolved
Hide resolved
anderson-joyle
force-pushed
the
andersonf/2795-predicate-warning
branch
from
b81a987 to
f452aaa
Compare
Contributor
|
✅ No public API change. #Resolved |
1 similar comment
Contributor
|
✅ No public API change. #Resolved |
anderson-joyle
force-pushed
the
andersonf/2795-predicate-warning
branch
from
0874948 to
16a12da
Compare
Contributor
|
✅ No public API change. #Resolved |
Contributor
|
✅ No public API change. #Closed |
Contributor
|
✅ No public API change. #Closed |
anderson-joyle
dismissed stale reviews from MikeStall and CarlosFigueiraMSFT
via
a279f20
Contributor
|
✅ No public API change. #Closed |
anderson-joyle
force-pushed
the
andersonf/2795-predicate-warning
branch
from
a279f20 to
d387f0c
Compare
Contributor
|
✅ No public API change. #Closed |
MikeStall
reviewed
Mar 24, 2025
| !node.Args.ChildNodes.Any(child => child is ErrorNode) && | ||
| TryGetCall(node.Id, out var callInfo)) | ||
| { | ||
| //func.ScopeInfo.CheckPredicateFields(GetUsedScopeFields(callInfo), node, GetLambdaParamNames(callInfo.ScopeNest + 1), ErrorContainer); |
anderson-joyle
force-pushed
the
andersonf/2795-predicate-warning
branch
from
d387f0c to
fbe58c8
Compare
Contributor
|
✅ No public API change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2795.
The original issue was meant to check
Joinfunction predicate. I'm expanding the analysis.This pull request introduces several changes to improve error handling and predicate checking in the Microsoft PowerFx library. The most significant changes include adding severity-based error checking and modifying function scope checking.