Fixes a bug where the JSON function with JSONFormat.FlattenValueTables argument was not working correctly when the input value is an IUntypedObject.#3012
Open
Robulane wants to merge 4 commits intomicrosoft:mainfrom
Conversation
src/libraries/Microsoft.PowerFx.Json/Functions/JsonFunctionImpl.cs
Outdated
Show resolved
Hide resolved
3009b47 to
4ab5811
Compare
4ab5811 to
fcb24f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where the JSON function with JSONFormat.FlattenValueTables argument was not working correctly when the input value is an IUntypedObject.
Problem
When JSON function received an IUntypedObject representing an array of single-column "Value" objects (like
[{Value:1},{Value:2},{Value:3}]), the JSONFormat.FlattenValueTables argument was being ignored. The function would output the full object structure[{"Value":1},{"Value":2},{"Value":3}]instead of the flattened version[1,2,3].Root Cause
In JsonFunctionImpl.cs, the Visit(IUntypedObject) method processed arrays without checking the _flattenValueTables flag, unlike the Visit(TableValue) method which correctly handled this flag.
Changes Made
Test plan