Settings: Mouse utils setting crash - #41050
Merged
Merged
Conversation
yeelam-gordon
approved these changes
Aug 8, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash in the settings page that was caused by an incorrect converter reference. The issue was that the code was using a non-existent converter name BoolToReverseVisibilityConverter instead of the correct ReverseBoolToVisibilityConverter.
- Corrected a converter reference from
BoolToReverseVisibilityConvertertoReverseBoolToVisibilityConverter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fix a crash in settings page due to not found converter
AI Summary
This pull request makes a small update to the
MouseUtilsPage.xamlfile to use the correct resource for converting boolean values to visibility states in the UI.Visibilitybinding on anInfoBarto use theReverseBoolToVisibilityConverterinstead of the incorrectBoolToReverseVisibilityConverterresource.PR Checklist
Detailed Description of the Pull Request / Additional comments
Regression caused by #40214
Validation Steps Performed