chore: Try 100% Code Coverage by ranadeepsingh · Pull Request #2507 · microsoft/SynapseML

ranadeepsingh · 2026-02-27T11:12:14Z

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

No. You can skip this section.
Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

No. You can skip this section.
Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add  before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

github-actions · 2026-02-27T11:12:26Z

Hey @ranadeepsingh 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

fix: Fix LightGBM crashes with empty partitions
feat: Make HTTP on Spark back-offs configurable
docs: Update Spark Serving usage
build: Add codecov support
perf: improve LightGBM memory usage
refactor: make python code generation rely on classes
style: Remove nulls from CNTKModel
test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

ranadeepsingh · 2026-02-27T11:13:10Z

/azp run

azure-pipelines · 2026-02-27T11:13:23Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-27T13:24:53Z

/azp run

azure-pipelines · 2026-02-27T13:25:06Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR updates the build’s scoverage configuration to exclude specific packages from coverage reporting, and adds/updates Scala unit tests in core to increase coverage around logging/common utilities and various constant/schema helpers.

Changes:

Add scoverage exclusions (and related scoverage settings) in build.sbt.
Update Python package metadata generation in PyCodegen (license metadata/classifiers).
Add/refresh Scala tests for logging utilities, schema helpers, metric/constants, OS/platform detection, and param/metric contracts.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
core/src/test/scala/com/microsoft/azure/synapse/ml/logging/common/VerifyScrubber.scala	Refresh SASScrubber tests to better match the current regex behavior and add edge cases.
core/src/test/scala/com/microsoft/azure/synapse/ml/logging/common/VerifyPlatformDetails.scala	Expand PlatformDetails test coverage (constants + platform detection helpers).
core/src/test/scala/com/microsoft/azure/synapse/ml/logging/VerifySynapseMLLogging.scala	New tests for logging field structs and SynapseMLLogging mappings/state.
core/src/test/scala/com/microsoft/azure/synapse/ml/logging/VerifyFeatureNames.scala	New tests asserting FeatureNames constants.
core/src/test/scala/com/microsoft/azure/synapse/ml/core/utils/VerifyOsUtils.scala	New tests for OsUtils.IsWindows.
core/src/test/scala/com/microsoft/azure/synapse/ml/core/schema/VerifySchemaConstants.scala	New tests asserting SchemaConstants values.
core/src/test/scala/com/microsoft/azure/synapse/ml/core/schema/VerifyImageSchemaUtils.scala	New tests for ImageSchemaUtils schemas and `isImage` helpers.
core/src/test/scala/com/microsoft/azure/synapse/ml/core/schema/VerifyBinaryFileSchema.scala	New tests for BinaryFileSchema schemas and helpers.
core/src/test/scala/com/microsoft/azure/synapse/ml/core/metrics/VerifyMetricConstants.scala	New tests asserting MetricConstants values and collections.
core/src/test/scala/com/microsoft/azure/synapse/ml/core/env/VerifyPackageUtils.scala	New tests for PackageUtils derived values and coordinates.
core/src/test/scala/com/microsoft/azure/synapse/ml/core/contracts/VerifyParams.scala	New tests for param traits’ setters/getters and chaining behavior.
core/src/test/scala/com/microsoft/azure/synapse/ml/core/contracts/VerifyMetrics.scala	New tests for metrics contract case classes and helper constructors.
core/src/main/scala/com/microsoft/azure/synapse/ml/codegen/PyCodegen.scala	Adjust generated `setup.py` metadata (license_expression and classifiers).
build.sbt	Add scoverage excluded packages and settings.

core/src/test/scala/com/microsoft/azure/synapse/ml/logging/VerifySynapseMLLogging.scala

core/src/test/scala/com/microsoft/azure/synapse/ml/logging/common/VerifyPlatformDetails.scala

core/src/test/scala/com/microsoft/azure/synapse/ml/logging/VerifySynapseMLLogging.scala

ranadeepsingh · 2026-02-27T13:33:33Z

/azp run

azure-pipelines · 2026-02-27T13:33:45Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-27T13:37:52Z

/azp run

azure-pipelines · 2026-02-27T13:38:04Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-27T14:07:36Z

@codecov-commenter update

ranadeepsingh · 2026-02-27T14:48:41Z

/azp run

azure-pipelines · 2026-02-27T14:48:55Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-27T15:08:16Z

/azp run

azure-pipelines · 2026-02-27T15:08:29Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-27T16:00:33Z

/azp run

azure-pipelines · 2026-02-27T16:33:29Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-27T16:35:39Z

/azp run

azure-pipelines · 2026-02-27T16:35:52Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-27T16:48:16Z

/azp run

azure-pipelines · 2026-02-27T16:48:28Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-27T17:41:46Z

/azp run

azure-pipelines · 2026-02-27T17:41:59Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-27T17:56:12Z

/azp run

azure-pipelines · 2026-02-27T17:56:26Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-27T18:06:44Z

/azp run

azure-pipelines · 2026-02-27T18:06:57Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-27T18:38:02Z

/azp run

azure-pipelines · 2026-02-27T18:38:15Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-27T23:20:31Z

/azp run

azure-pipelines · 2026-02-27T23:20:45Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-28T00:05:41Z

/azp run

azure-pipelines · 2026-02-28T00:05:53Z

Azure Pipelines successfully started running 1 pipeline(s).

ranadeepsingh · 2026-02-28T00:40:42Z

/azp run

azure-pipelines · 2026-02-28T00:40:54Z

Azure Pipelines successfully started running 1 pipeline(s).

codecov-commenter · 2026-02-28T01:17:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.18%. Comparing base (5d4a3ef) to head (de5517c).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2507      +/-   ##
==========================================
+ Coverage   84.61%   86.18%   +1.56%     
==========================================
  Files         334      321      -13     
  Lines       17669    17173     -496     
  Branches     1625     1532      -93     
==========================================
- Hits        14951    14800     -151     
+ Misses       2718     2373     -345

Files with missing lines	Coverage Δ
...ft/azure/synapse/ml/logging/SynapseMLLogging.scala	`91.80% <100.00%> (ø)`
...icrosoft/azure/synapse/ml/param/GlobalParams.scala	`92.30% <ø> (ø)`

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Add code cov exclusions

5b26130

Add more test cov

b257fee

ranadeepsingh requested a review from Copilot February 27, 2026 13:24

Copilot started reviewing on behalf of ranadeepsingh February 27, 2026 13:25 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Fix style issues

e26e17c

ranadeepsingh added 2 commits February 27, 2026 05:35

Fix errorType and errorMessage

961fe67

Fix with copilot suggestions

c57cff9

ranadeepsingh added 2 commits February 27, 2026 06:48

Publish code coverage to ADO pipeline

70709d4

Add new code cov comments to Github PR

78455ea

ranadeepsingh changed the title ~~chore: Add code cov exclusions~~ chore: Try 100% Code Coverage Feb 27, 2026

Reduce 4x code cov comments

9d2cb55

Add more tests

05e5a5f

ranadeepsingh requested review from imatiach-msft and memoryz as code owners February 27, 2026 16:00

Fix scala warnings for deprecated styling

babfee4

Fix more warnings

8e39ada

More tests

8094a65

Fix PR validation and compile issues

4269a5c

Fix scala style

b7ee0b3

Fix more

16c2917

Add more and more tests

66bc7b3

ranadeepsingh added 2 commits February 27, 2026 15:54

Add scala code skill

4761086

Fix linting issues

030670d

Add more tests

de5517c

Conversation

ranadeepsingh commented Feb 27, 2026

Related Issues/PRs

What changes are proposed in this pull request?

How is this patch tested?

Does this PR change any dependencies?

Does this PR add a new feature? If so, have you added samples on website?

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 27, 2026

Uh oh!

azure-pipelines bot commented Feb 27, 2026

Uh oh!

ranadeepsingh commented Feb 28, 2026

Uh oh!

azure-pipelines bot commented Feb 28, 2026

Uh oh!