Spaceship by HakiRose · Pull Request #190 · microsoft/TextWorld

HakiRose · 2019-10-21T20:56:00Z

The design of mid-level game is finalized.

MarcCote · 2019-10-29T13:29:31Z

@HakiRose the current version doesn't work for me. I can't run
tw-make --third-party spaceship_game.py tw-spaceship --level medium

Also, it seems to be missing the logic for the type cpu.

textworld/challenges/spaceship/maker.py

textworld/challenges/spaceship/spaceship_game.py

HakiRose · 2019-10-29T13:45:35Z

@HakiRose the current version doesn't work for me. I can't run
tw-make --third-party spaceship_game.py tw-spaceship --level medium

Also, it seems to be missing the logic for the type cpu.

The first comment is exactly the issue I have, and I wanna to talk with you.

MarcCote · 2019-10-29T13:54:38Z

You might have forgotten to git add relevant .twl files.

MarcCote

Here are a few comments.

MarcCote · 2019-11-11T16:25:14Z

textworld/envs/glulx/git_glulx_ml.py

        if mode == 'ansi':
            return outfile
+
+    def seed(self, seed=4567, init_seed=None):


The signature of the seed method should be the same as in textworld.core.Environment.seed (https://github.com/microsoft/TextWorld/blob/master/textworld/core.py#L204)

This function should simply set the in-game rng seed with the seed passed in argument.

Changing the seed between the episode should be handled by the agent's code.

I need to discuss this comment with you.

MarcCote · 2019-11-11T16:33:09Z

textworld/generator/data/text_grammars/Spaceship.twg

@@ -0,0 +1,964 @@
+#----------------------------------------------------------------------------------------------------------------------------------


This file should not be in textworld/data/text_grammars/. Remove this one and keep, only the one in challenges.

MarcCote · 2019-11-11T16:47:21Z

textworld/challenges/spaceship/spaceship_game.py

+    quests.append(Quest(win_events=[win_quest], fail_events=[]))
+    # fail_quest = Event(conditions={game.new_fact("unread/e", game._named_entities['laptop']),
+    #                                game.new_fact("open", game._named_entities['door A'])})
+    fail_quest = Event(conditions={game.new_fact("unread/e", game._entities['cpu_0']),


I think the losing condition should be "unread email" and "the player has left the room" instead of the door being open.

By this: "the player has left the room", do you mean the return msg from Inform7?

No. More like at(P, new_room) & unread(email) or something like that.

MarcCote · 2019-11-11T16:53:04Z

textworld/challenges/spaceship/textworld_data/logic/CPU.twl

+            checking email is an action applying to nothing. 
+
+            Carry out checking email: 
+                if a CPU-like (called pc) is unread:                     


It's better to also say something when the email is read. Maybe something like "You've already read all today's emails."

Good idea, done!

MarcCote · 2019-11-11T16:53:32Z

textworld/challenges/spaceship/textworld_data/logic/CPU.twl

+                if a CPU-like (called pc) is unread:                     
+                    if a random chance of 1 in 4 succeeds: 
+                        Now the pc is read; 
+                        Say "Email: Your mission is started.";                                                                       


Ideally, we want to describe the mission here.

ohoom! I'll consider a good description for this part.
Anyways, I'd like to discuss another topic, but relevant to this, with you.

MarcCote · 2019-11-11T16:55:09Z

textworld/challenges/spaceship/textworld_data/logic/thing.twl

+        }
+
+        code :: """
+            Understand "tw-set seed [a number]" as updating the new seed. 


That seems to work great!

Yes! But there is a minor thing I'd like to share with you and have your opinion :
@ git_glulx_ml.py:
GitGlulxMLEnvironment.seed()
The increment is not 1, rather it is a random int. What do you think?

MarcCote · 2019-11-11T16:57:22Z

textworld/challenges/spaceship/textworld_data/logic/CPU.twl

+    }
+
+    reverse_rules {
+        check/e     :: check/e;


Those are not valid reverse rules. You can't uncheck email nor unexamine cpu. Not all actions have a way to reverse their effects.

Well my understanding about this was a bit different! Let me describe it, & pls correct me if I'm wrong:
I assumed that the reverse actions provides the return to previous state as ell as repetition of an action (e.g. examine/door :: examine/door). Since we need to have check email in the "available actions" array whenever the player is in Sleeping Station, I decided to have return rule for check/e. What do you think?

MarcCote · 2019-11-11T17:00:17Z

textworld/challenges/spaceship/textworld_data/logic/CPU.twl

+
+        commands {            
+            check/e     :: "check email"    :: "checking email";
+            examine/cpu :: "examine {cpu}"  :: "examining the {cpu}";


I don't think you need examine/cpu because it is inherited from examine/o.

Oh! so if I don't mention it, still it will be there in "action array"? Like inheritance in classes...?!

MarcCote · 2019-11-11T17:02:29Z

textworld/challenges/spaceship/textworld_data/logic/CPU.twl

+        code :: """
+            Understand the command "check" as something new. 
+            Understand "check email" as checking email. 
+            checking email is an action applying to nothing. 


Because "checking email" is an action that applies to nothing, it means that Inform/the game will understand the command "check email" everywhere in the game (i.e. not necessarily in front of the laptop).

I think it would be better if "email" is an entity in the game that we can interact with. Or even better, maybe we should support a command like: "check laptop for email", "check email on/using laptop". It's not clear to me how we can do it though.

I'll implement it.

…- Push_button and Cloth are assumed simply as key and object, respectively.

author HakiRose <hakimeh.pourmehdi@gmail.com> 1567777575 -0400 committer HakiRose <hakimeh.pourmehdi@gmail.com> 1582743626 -0500 Medium-level Spaceship game -- cloth(finished), Push button (in progress)

…ding system

…l) is implemented, revisions on FW for stochastic commands, some minor changes on a few other files.

… and refactoring, game files(json, ni, ulx), updated logic files, ...

MarcCote requested changes Oct 29, 2019

View reviewed changes

textworld/challenges/spaceship/maker.py Show resolved Hide resolved

textworld/challenges/spaceship/spaceship_game.py Outdated Show resolved Hide resolved

MarcCote reviewed Oct 29, 2019

View reviewed changes

textworld/challenges/spaceship/spaceship_game.py Outdated Show resolved Hide resolved

MarcCote requested changes Nov 11, 2019

View reviewed changes

HakiRose added 13 commits February 26, 2020 13:41

The text grammar of Spaceship game

33c795f

Spaceship making file, some modifications on grammar_maker

e375e2f

The spaceship game maker file

6f1fae7

The customized text grammar and logics of spaceship game

5ed900b

This is the design of the infrastructure of medium level of the game …

47757f1

…- Push_button and Cloth are assumed simply as key and object, respectively.

parent 47757f1

dbcd1b1

author HakiRose <hakimeh.pourmehdi@gmail.com> 1567777575 -0400 committer HakiRose <hakimeh.pourmehdi@gmail.com> 1582743626 -0500 Medium-level Spaceship game -- cloth(finished), Push button (in progress)

push button updated logic and files

5bcaed7

A new update to midium level game: Add conditions to change th erewar…

2ddb67e

…ding system

The original Spaceship game file is the spaceship_game.py

7029059

Registered game samples, Simple RL agent (already designed in tutoria…

db7fda3

…l) is implemented, revisions on FW for stochastic commands, some minor changes on a few other files.

the spaceship game: the latest version of the game, Framework updates…

6168512

… and refactoring, game files(json, ni, ulx), updated logic files, ...

The spaceship game - medium level v1.0 full package

99656ba

changes on spaceship_game after rebasing

cf62bab

HakiRose force-pushed the spaceship branch from f85bd58 to cf62bab Compare February 26, 2020 19:29

MarcCote changed the base branch from spaceship to master February 26, 2020 19:30

MarcCote force-pushed the main branch from f71aa01 to b49f035 Compare April 28, 2023 02:18

MarcCote force-pushed the main branch 8 times, most recently from 6ae5159 to 9b08db7 Compare January 28, 2026 16:56

MarcCote force-pushed the main branch 11 times, most recently from 5edccd6 to 9fce9ee Compare January 30, 2026 18:10

		@@ -0,0 +1,964 @@
		#----------------------------------------------------------------------------------------------------------------------------------

Conversation

HakiRose commented Oct 21, 2019

Uh oh!

MarcCote commented Oct 29, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HakiRose commented Oct 29, 2019

Uh oh!

MarcCote commented Oct 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarcCote left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MarcCote commented Oct 29, 2019 •

edited

Loading