New event style by HakiRose · Pull Request #218 · microsoft/TextWorld

HakiRose · 2020-02-24T20:06:51Z

The Traceables!

…- Push_button and Cloth are assumed simply as key and object, respectively.

author HakiRose <hakimeh.pourmehdi@gmail.com> 1567777575 -0400 committer HakiRose <hakimeh.pourmehdi@gmail.com> 1582743626 -0500 Medium-level Spaceship game -- cloth(finished), Push button (in progress)

…ding system

…l) is implemented, revisions on FW for stochastic commands, some minor changes on a few other files.

… and refactoring, game files(json, ni, ulx), updated logic files, ...

… adapt the new Predicate, Proposition, & Signature styles. This new framework can track a proposition through the time.

…nt of proposition.activate, etc.

… the fully operating structure of the FW

…w quest/Event design, new world2inform7 structure, and more.

…opments on test files, some updates on the frame work, semi-final updates on Content Check Game, etc.

MarcCote

@HakiRose I've made a first pass. Next, I'll dig into game.py and logic/__init__.py. But before I do so, can you confirm the code still needs "verb" and "definition" in Proposition?

MarcCote · 2020-05-12T19:34:48Z

textworld/generator/game.py

+                state.remove_fact(prop)
+
+    def has_traceable(self):
+        for prop in self.get_facts():


This class doesn't seem to have a method called get_facts.

MarcCote · 2020-05-12T19:36:26Z

textworld/generator/game.py



-class Event:
+class PropositionControl:


This class doesn't seem to have corresponding unit tests.

MarcCote · 2020-05-12T19:39:30Z

textworld/logic/parser.py

            []
        )

+    def _predVT_(self, name):


This file is automatically generated by TatSu depending on the content of textworld/logic/logic.ebnf upon making a new TextWorld release. This means you shouldn't/can't modify it directly. Instead, you must modify logic.ebnf accordingly.

MarcCote · 2020-05-12T19:39:43Z

textworld/logic/model.py

 class SignatureNode(ModelBase):
    name = None
    types = None
+    verb = None


This file is automatically generated by TatSu depending on the content of textworld/logic/logic.ebnf upon making a new TextWorld release. This means you shouldn't/can't modify it directly. Instead, you must modify logic.ebnf accordingly.

MarcCote · 2020-05-12T19:41:23Z

textworld/generator/world.py

        # Handle door link facts.
        for fact in self.facts:
-            if fact.name != "link":
+            if fact.name != "is__link":


For backward compatibility (very important), we should support not having an is__ by default.

MarcCote · 2020-05-12T19:51:22Z

textworld/generator/inform7/world2inform7.py

+        for ph, var in mapping.items():
+            a = ph.name
+            b = self.entity_infos[var.name].name


It doesn't seem to be used.

MarcCote · 2020-05-12T19:55:14Z

textworld/logic/__init__.py


        return "\n".join(lines)
+
+    def get_facts(self):


What's the difference with the property .facts?

MarcCote · 2020-05-12T19:56:49Z

.gitignore

 *.ipynb_checkpoints
 /dist
 /wheelhouse
+*.orig


Good idea. The branch associated with this PR already contains a bunch of .orig files, though.

MarcCote · 2020-05-12T19:58:33Z

textworld/challenges/spaceship/RL_agent_design_a2c.py

@@ -0,0 +1,341 @@
+from collections import defaultdict


Let's remove the spaceship challenge from this PR to keep the changes manageable (for me) to review ;)

MarcCote · 2020-05-12T20:00:40Z

textworld/generator/__init__.py

            actions.append(chain.actions[i - 1])
            if chain.nodes[i].breadth != chain.nodes[i - 1].breadth:
-                event = Event(actions)
+                event = EventCondition(actions)


Since actions is not the first parameters of the constructor anymore, you need to write actions=actions.

HakiRose requested a review from MarcCote February 24, 2020 20:06

HakiRose added 19 commits February 26, 2020 13:41

The text grammar of Spaceship game

33c795f

Spaceship making file, some modifications on grammar_maker

e375e2f

The spaceship game maker file

6f1fae7

The customized text grammar and logics of spaceship game

5ed900b

This is the design of the infrastructure of medium level of the game …

47757f1

…- Push_button and Cloth are assumed simply as key and object, respectively.

parent 47757f1

dbcd1b1

author HakiRose <hakimeh.pourmehdi@gmail.com> 1567777575 -0400 committer HakiRose <hakimeh.pourmehdi@gmail.com> 1582743626 -0500 Medium-level Spaceship game -- cloth(finished), Push button (in progress)

push button updated logic and files

5bcaed7

A new update to midium level game: Add conditions to change th erewar…

2ddb67e

…ding system

The original Spaceship game file is the spaceship_game.py

7029059

Registered game samples, Simple RL agent (already designed in tutoria…

db7fda3

…l) is implemented, revisions on FW for stochastic commands, some minor changes on a few other files.

the spaceship game: the latest version of the game, Framework updates…

6168512

… and refactoring, game files(json, ni, ulx), updated logic files, ...

The spaceship game - medium level v1.0 full package

99656ba

changes on spaceship_game after rebasing

cf62bab

New project to implement the EventAction class

1c49af3

new changes on content_check branch after rebasing

878b9fe

temporary uploads

a319361

The new style of TRACEABLE PROPOSITIONS and comprehenssive updates to…

9c003c0

… adapt the new Predicate, Proposition, & Signature styles. This new framework can track a proposition through the time.

Some updates on Traceable controling process, removed redundant eleme…

0c9040f

…nt of proposition.activate, etc.

updates on New_event_style after rebasing

4de1ba6

HakiRose force-pushed the New_event_Style branch from 9d3f78e to 4de1ba6 Compare February 26, 2020 23:28

HakiRose added 3 commits February 28, 2020 13:16

The new updates over the NEW STYLE of the FRAMEWORK after the rebase,…

3810348

… the fully operating structure of the FW

New TextWorld framework structure includes: new quest description, ne…

14071ae

…w quest/Event design, new world2inform7 structure, and more.

Updates on new TextWorld framework structure include: updates & devel…

5a77916

…opments on test files, some updates on the frame work, semi-final updates on Content Check Game, etc.

MarcCote requested changes May 12, 2020

View reviewed changes

This was referenced May 14, 2020

ENH: support composing Event objects #234

Closed

ENH: New Event classes #235

Open

MarcCote force-pushed the main branch from f71aa01 to b49f035 Compare April 28, 2023 02:18

MarcCote force-pushed the main branch 2 times, most recently from 5e7cc23 to a7f6017 Compare January 27, 2026 19:43

MarcCote force-pushed the main branch 17 times, most recently from 5edccd6 to 9fce9ee Compare January 30, 2026 18:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New event style#218

New event style#218
HakiRose wants to merge 22 commits intomicrosoft:mainfrom
HakiRose:New_event_Style

HakiRose commented Feb 24, 2020

Uh oh!

MarcCote left a comment

Uh oh!

MarcCote May 12, 2020

Uh oh!

MarcCote May 12, 2020

Uh oh!

MarcCote May 12, 2020

Uh oh!

MarcCote May 12, 2020

Uh oh!

MarcCote May 12, 2020

Uh oh!

MarcCote May 12, 2020

Uh oh!

MarcCote May 12, 2020

Uh oh!

MarcCote May 12, 2020

Uh oh!

MarcCote May 12, 2020

Uh oh!

MarcCote May 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

HakiRose commented Feb 24, 2020

Uh oh!

MarcCote left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants