Inform about useDefineForClassFields breaking change in TS >=4.3#292
Open
rangoo94 wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I've been upgrading the TypeScript, I encountered multiple strange issues, related to abstract classes. It took me a while to detect what was the problems reason, as I haven't found in any notes information about
useDefineForClassFieldsoption.It's changing the default behaviour, which may easily break the existing code. I added simplest example as possible in this PR, as I felt that my specific example may be too specific, while this simplified example may help to identify issue anyway.
The exact problem I encountered:
Took me a while to detect the culprit, so I think that it's worth to add information about that to documentation, so it will reduce problems with migration.