fix: remove unregistered Windows App SDK PyPI dependencies (dependency confusion)#27
Open
x4v13r64 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: remove unregistered Windows App SDK PyPI dependencies (dependency confusion)#27x4v13r64 wants to merge 1 commit intomicrosoft:mainfrom
x4v13r64 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…y confusion) onnxruntime-winml is not published to PyPI; references in requirements.txt files allow an attacker to register the name and intercept installs. winappsdk-Foundation and winappsdk-InteractiveExperiences are likewise not on PyPI; they are distributed via local wheels. Remove bare package names and add comments directing users to the correct distribution channel.
Contributor
|
@x4v13r64 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes Python package names from
requirements.txtandpyproject.tomlfiles that do not exist on PyPI and are therefore squattable by an attacker (dependency confusion).Affected packages and files:
onnxruntime-winml— removed from:WindowsAppSDK-Samples/2.0-stable/WindowsML/python/SqueezeNetPython/requirements.txtWindowsAppSDK-Samples/1.8-stable/WindowsML/python/SqueezeNetPython/requirements.txtwinappsdk-Foundation,winappsdk-InteractiveExperiences— removed from:WindowsAppSDK-ProjectTemplates/python/sparse/pyproject.tomlWindowsAppSDK-ProjectTemplates/python/unpackaged/pyproject.tomlWindowsAppSDK-ProjectTemplates/python/packaged/pyproject.tomlNone of these packages are published to PyPI. When a developer runs
pip install -r requirements.txtorpip install .(for the templates), pip queries PyPI for each listed name. An attacker can register these names on PyPI and have arbitrary code executed on the installing machine.Comments have been added in each file directing users to the correct Windows App SDK distribution channel.
Test plan
pip install -r WindowsAppSDK-Samples/2.0-stable/WindowsML/python/SqueezeNetPython/requirements.txtno longer attempts to fetchonnxruntime-winmlfrom PyPIpip install -r WindowsAppSDK-Samples/1.8-stable/WindowsML/python/SqueezeNetPython/requirements.txtno longer attempts to fetchonnxruntime-winmlfrom PyPIpip install .in each ProjectTemplates directory no longer attempts to fetchwinappsdk-Foundationorwinappsdk-InteractiveExperiencesfrom PyPI