-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Python: Add middleware sample to show filtering messages between agents (#3556) #6143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
pratik wayase (PratikWayase)
wants to merge
2
commits into
microsoft:main
from
PratikWayase:feat/middleware-message-filter-sample-3556
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this closes #3556 as written. The issue asks for message interception between agents, but this sample wraps
workflow.run()and post-processes emitted events after the group chat internals have already consumed the participant response. That means a dropped/redacted message can still be appended to the orchestrator conversation and broadcast to other participants before the wrapper sees it.There are also current API mismatches:
agent_framework.Eventis not exported,Messageusescontents=[...]rather thantext=...,Messagehas noreplace()method,WorkflowEventis not a dataclass sodataclasses.replace(event, ...)will not work, and streamed updates are emitted asoutputevents rather thanintermediateevents.I think the best way to make this sample match #3556 is to show a custom
BaseGroupChatOrchestratorthat applies the interceptor before participant messages are appended to group-chat state or broadcast to other participants.An executor/participant wrapper can transform an
AgentExecutorResponse, but that feels less aligned with the issue: the request is specifically about message interception between agents in group chat. The orchestrator is already the central routing point for participant responses, speaker selection, and broadcasts, so it is the clearest place to demonstrate content filtering, message transformation, and access control without implying that caller-facingworkflow.run()events are the actual inter-agent message channel.p.s. I'd also prefer a better name for the sample too, please. And it needs to be added to the workflows samples README. Thanks.