Python: fix invalid options kwarg in workflow shared session sample - #6294
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 4 commits intoJul 8, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the shared-session agents workflow sample to pass message storage configuration via client_kwargs instead of options.
Changes:
- Reworded the inline comment to describe
client_kwargsforwarding behavior. - Renamed
options={"store": False}toclient_kwargs={"store": False}in theworkflow.run(...)call.
…ample Workflow.run() does not accept an options parameter. The store=False kwarg was silently ignored. Use client_kwargs to correctly forward it to the underlying chat client. Fixes microsoft#6293
Benke Qu (benke520)
force-pushed
the
fix/workflow-sample-invalid-options-kwarg
branch
from
June 3, 2026 00:10
bd0eedf to
0088471
Compare
Member
Author
|
Evan Mattson (@moonbox3) Hey! Could you do a quick review on this one when you get a chance? It's a small fix - swaps |
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Jul 8, 2026
Eduard van Valkenburg (eavanvalkenburg)
enabled auto-merge
July 8, 2026 08:07
Evan Mattson (moonbox3)
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Fixes #6293
Problem
azure_ai_agents_with_shared_session.pypassesoptions={"store": False}toworkflow.run(), butWorkflow.run()does not accept anoptionsparameter. The kwarg is silently absorbed by Python andstore=Falseis never forwarded to the chat client.Fix
Replace
options={"store": False}withclient_kwargs={"store": False}, which correctly forwards the parameter to the underlying chat client calls viaWorkflow.run()'sclient_kwargsparameter.