.NET: Python: .NET: Make skill resource guidance rule-only - #7664
Draft
Sam (samrusani) wants to merge 1 commit into
Draft
.NET: Python: .NET: Make skill resource guidance rule-only#7664Sam (samrusani) wants to merge 1 commit into
Sam (samrusani) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes fictional skill resource examples from Python and .NET prompts while preserving explicit resource discovery.
Changes:
- Replaces examples with equivalent rule-only guidance.
- Adds prompt regressions and explicit-path positive controls.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
python/packages/core/agent_framework/_skills.py |
Updates Python resource guidance. |
python/packages/core/tests/core/test_skills.py |
Adds Python regression coverage. |
dotnet/src/Microsoft.Agents.AI/Skills/AgentSkillsProvider.cs |
Updates .NET resource guidance. |
dotnet/tests/Microsoft.Agents.AI.UnitTests/AgentSkills/AgentSkillsProviderTests.cs |
Adds .NET regression coverage. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
AgentSkillsProvidercurrently places fictional resource names in the defaultPython and .NET instructions. A model can mistake those examples for resources
that the loaded skill actually provides and make a guaranteed-to-fail
read_skill_resourcecall.This change keeps resource access grounded in the loaded skill while preserving
the existing resource discovery and tool APIs.
Fixes #7663
Description & Review Guide
matching rule-only guidance: read only explicitly referenced resources,
preserve the referenced path exactly, and never infer resource paths.
examples.
exactly when the loaded skill explicitly provides it.
names. Public APIs and valid resource listings are unchanged.
.NET and that the C# assertions match the existing skills-test conventions.
The focused Python regressions fail against the base prompt and pass with this
change. The complete Python
test_skills.pyfile and core syntax checks pass.The .NET tests were not run locally because the .NET CLI was unavailable; draft
CI is expected to provide that validation.
Related Issue
Fixes #7663
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.