Skip to content

fix(opencode): upgrade js-yaml to 4.3.1 - #3678

Open
Kerberosmansour (kerberosmansour) wants to merge 1 commit into
microsoft:mainfrom
kerberosmansour:agent/fix-3671-js-yaml-4-3-1
Open

fix(opencode): upgrade js-yaml to 4.3.1#3678
Kerberosmansour (kerberosmansour) wants to merge 1 commit into
microsoft:mainfrom
kerberosmansour:agent/fix-3671-js-yaml-4-3-1

Conversation

@kerberosmansour

@kerberosmansour Kerberosmansour (kerberosmansour) commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • raise the OpenCode package's transitive js-yaml override from 4.2.0 to 4.3.1
  • regenerate the lockfile and verify that production dependency audit findings are cleared
  • add a dependency audit record with rationale, validation, compatibility, and rollback notes

Security rationale

Version 4.3.0 addresses GHSA-52cp-r559-cp3m, but remains affected by GHSA-5p4m-2wfm-xmqj. Version 4.3.1 is therefore the first 4.x release that resolves both high-severity quadratic-CPU advisories.

Validation

  • cd agent-governance-opencode && npm run check — 25/25 tests passed
  • cd agent-governance-opencode && npm audit --omit=dev — 0 vulnerabilities
  • documentation link and frontmatter checks passed
  • changed-line spelling and whitespace checks passed

Closes #3671

Tracking

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 10, 2026
@github-actions

Copy link
Copy Markdown

PR Review Summary

Check Status Details
🔍 Code Review ⚠️ Missing No current-run comment
🛡️ Security Scan ⚠️ Missing No current-run comment
🔄 Breaking Changes ⚠️ Missing No current-run comment
📝 Docs Sync ⚠️ Missing No current-run comment
🧪 Test Coverage ⚠️ Missing No current-run comment

Verdict: ⚠️ AI review incomplete; ready for human review

AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims.

@github-actions github-actions Bot added the size/M Medium PR (< 200 lines) label Aug 10, 2026
@github-actions

Copy link
Copy Markdown

🟡 Contributor Check: MEDIUM

Check Result
Profile MEDIUM
Credential MEDIUM
Overall MEDIUM

Automated check by AGT Contributor Check.

@github-actions github-actions Bot added the needs-review:MEDIUM Contributor check flagged MEDIUM risk label Aug 10, 2026
@kerberosmansour
Kerberosmansour (kerberosmansour) marked this pull request as ready for review August 10, 2026 22:11
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked your advisory reasoning against the GitHub Advisory Database rather than taking it, because I had pulled the same data earlier today for a different js-yaml audit and wanted to be sure the two agreed.

They do, and the distinction you drew is the one that matters:

  • GHSA-52cp-r559-cp3m — affects >= 4.0.0, < 4.3.0, first patched 4.3.0
  • GHSA-5p4m-2wfm-xmqj — affects >= 4.0.0, < 4.3.1, first patched 4.3.1

So 4.3.1 is the first 4.x release clearing both, and 4.3.0 would have looked sufficient to anyone who stopped at the first advisory. Getting that right is the whole value of the change. Including the audit doc with rollback notes rather than leaving it for someone else is the other half.

The red Validate docs frontmatter is not yours. scripts/docs/check_frontmatter.py --root . scans the whole repository, and the finding is:

[error] docs/security/audits/2026-07-31-fail-open-closure-python-reference.md: missing frontmatter block

Your PR does not touch that file. It was fixed by #3619, which merged today at 18:46, and your branch's last commit is from 2026-08-10, so it predates the fix. I ran the gate against current main: 279 files scanned, 0 findings.

A rebase onto main clears it with no change to your work. Any branch cut before today that touches docs/ inherits the same failure, which is also why dependabot #3598 is currently red on this exact check.

Your own doc's frontmatter is fine, for what it is worth: title, last_reviewed and owner are all present and correctly formed.

No approve bit on this repo, so this is a comment, but once it is rebased I would merge it.

Signed-off-by: kerberosmansour <13433538+kerberosmansour@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation needs-review:MEDIUM Contributor check flagged MEDIUM risk size/M Medium PR (< 200 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security]: upgrade js-yaml to 4.3.1 or remove it from the OpenCode path

2 participants