fix(opencode): upgrade js-yaml to 4.3.1 - #3678
fix(opencode): upgrade js-yaml to 4.3.1#3678Kerberosmansour (kerberosmansour) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
|
🟡 Contributor Check: MEDIUM
Automated check by AGT Contributor Check. |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Imran Siddique (imran-siddique)
left a comment
There was a problem hiding this comment.
Checked your advisory reasoning against the GitHub Advisory Database rather than taking it, because I had pulled the same data earlier today for a different js-yaml audit and wanted to be sure the two agreed.
They do, and the distinction you drew is the one that matters:
GHSA-52cp-r559-cp3m— affects>= 4.0.0, < 4.3.0, first patched4.3.0GHSA-5p4m-2wfm-xmqj— affects>= 4.0.0, < 4.3.1, first patched4.3.1
So 4.3.1 is the first 4.x release clearing both, and 4.3.0 would have looked sufficient to anyone who stopped at the first advisory. Getting that right is the whole value of the change. Including the audit doc with rollback notes rather than leaving it for someone else is the other half.
The red Validate docs frontmatter is not yours. scripts/docs/check_frontmatter.py --root . scans the whole repository, and the finding is:
[error] docs/security/audits/2026-07-31-fail-open-closure-python-reference.md: missing frontmatter block
Your PR does not touch that file. It was fixed by #3619, which merged today at 18:46, and your branch's last commit is from 2026-08-10, so it predates the fix. I ran the gate against current main: 279 files scanned, 0 findings.
A rebase onto main clears it with no change to your work. Any branch cut before today that touches docs/ inherits the same failure, which is also why dependabot #3598 is currently red on this exact check.
Your own doc's frontmatter is fine, for what it is worth: title, last_reviewed and owner are all present and correctly formed.
No approve bit on this repo, so this is a comment, but once it is rebased I would merge it.
Signed-off-by: kerberosmansour <13433538+kerberosmansour@users.noreply.github.com>
461fd5f to
99bb05a
Compare
Summary
js-yamloverride from 4.2.0 to 4.3.1Security rationale
Version 4.3.0 addresses GHSA-52cp-r559-cp3m, but remains affected by GHSA-5p4m-2wfm-xmqj. Version 4.3.1 is therefore the first 4.x release that resolves both high-severity quadratic-CPU advisories.
Validation
cd agent-governance-opencode && npm run check— 25/25 tests passedcd agent-governance-opencode && npm audit --omit=dev— 0 vulnerabilitiesCloses #3671
Tracking