Skip to content

chore(deps): bump agent-governance-sdk to 5.0.0 in the three CLI packages, with audit - #3721

Open
Imran Siddique (imran-siddique) wants to merge 6 commits into
mainfrom
chore/sdk-5-cli-packages
Open

chore(deps): bump agent-governance-sdk to 5.0.0 in the three CLI packages, with audit#3721
Imran Siddique (imran-siddique) wants to merge 6 commits into
mainfrom
chore/sdk-5-cli-packages

Conversation

@imran-siddique

Copy link
Copy Markdown
Collaborator

Consolidates #3686, #3683 and #3681, and adds the dependency audit that unblocks them.

Why they cannot land on their own

scripts/ci/vendored-patch-audit.sh exempts Dependabot only for non-major updates:

[ -n "$DEPENDABOT_UPDATE_TYPE" ] && \
[ "$DEPENDABOT_UPDATE_TYPE" != "version-update:semver-major" ]

These three run with DEPENDABOT_UPDATE_TYPE: version-update:semver-major, so the exemption does not apply and the gate requires an audit doc. It looks for that doc in the PR's own diff:

CHANGED_FILES=$(git diff --name-only "$BASE_REF"...HEAD)
AUDIT_DOC=$(grep -E '^docs/dependency-audits/[0-9]{4}-...' <<< "$CHANGED_FILES")

Dependabot does not write audit docs, so a semver-major Dependabot PR can never satisfy this gate on its own branch, and a separate doc PR would not satisfy it either. All three have been red on Dependency Audit Trail since 2026-08-11 for that reason, not because anything is wrong with them.

What this PR contains

The three Dependabot commits cherry-picked unchanged, plus one audit doc. Verified with git diff against each original head: package.json and package-lock.json in all three packages are byte-identical to what Dependabot produced. Their Signed-off-by: dependabot[bot] trailers are preserved, so authorship and DCO are intact.

bash scripts/ci/vendored-patch-audit.sh origin/main passes on this branch.

The finding worth reading

The audit is not a rubber stamp. This bump does not clear these packages of a js-yaml advisory.

  • Outgoing js-yaml 4.1.1 is in range for two HIGH advisories: GHSA-5p4m-2wfm-xmqj (patched 4.3.1) and GHSA-52cp-r559-cp3m (patched 4.3.0).
  • Incoming js-yaml 5.2.1, the SDK's own pin, is in range for GHSA-pm4m-ph32-ghv5, HIGH, >= 5.0.0, <= 5.2.1, first patched in 5.2.2. Current release is 5.2.3.

Two HIGH to one HIGH is the right direction and is not the same as clean. The durable fix is repinning js-yaml in the SDK rather than overriding it in three CLI lockfiles, so I have not attempted it here. Happy to open that separately if you want it.

Otherwise the risk is low. The SDK major is the monorepo-wide v5 version alignment from the [5.0.0] CHANGELOG entry, not an API break; the published 4.0.0 and 5.0.0 manifests agree on every @noble/* pin, on engines.node >=18.0.0 and on the license. Each of the three CLI packages already ships at 5.0.0 while pinning the 4.0.0 SDK, so this is the first time their published version and their SDK agree.

Suggested handling

Close #3686, #3683 and #3681 in favour of this, or tell me you would rather have three separate PRs each carrying its own copy of the doc and I will redo it that way.

dependabot Bot and others added 4 commits August 12, 2026 12:20
Bumps [@microsoft/agent-governance-sdk](https://github.com/microsoft/agent-governance-toolkit/tree/HEAD/agent-governance-typescript) from 4.0.0 to 5.0.0.
- [Release notes](https://github.com/microsoft/agent-governance-toolkit/releases)
- [Changelog](https://github.com/microsoft/agent-governance-toolkit/blob/main/CHANGELOG.md)
- [Commits](https://github.com/microsoft/agent-governance-toolkit/commits/v5.0.0/agent-governance-typescript)

---
updated-dependencies:
- dependency-name: "@microsoft/agent-governance-sdk"
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@microsoft/agent-governance-sdk](https://github.com/microsoft/agent-governance-toolkit/tree/HEAD/agent-governance-typescript) from 4.0.0 to 5.0.0.
- [Release notes](https://github.com/microsoft/agent-governance-toolkit/releases)
- [Changelog](https://github.com/microsoft/agent-governance-toolkit/blob/main/CHANGELOG.md)
- [Commits](https://github.com/microsoft/agent-governance-toolkit/commits/v5.0.0/agent-governance-typescript)

---
updated-dependencies:
- dependency-name: "@microsoft/agent-governance-sdk"
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@microsoft/agent-governance-sdk](https://github.com/microsoft/agent-governance-toolkit/tree/HEAD/agent-governance-typescript) from 4.0.0 to 5.0.0.
- [Release notes](https://github.com/microsoft/agent-governance-toolkit/releases)
- [Changelog](https://github.com/microsoft/agent-governance-toolkit/blob/main/CHANGELOG.md)
- [Commits](https://github.com/microsoft/agent-governance-toolkit/commits/v5.0.0/agent-governance-typescript)

---
updated-dependencies:
- dependency-name: "@microsoft/agent-governance-sdk"
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
The vendored-patch-audit gate greps the PR's own diff for the audit doc,
and exempts dependabot only for non-major updates, so a semver-major
bump opened by dependabot can never satisfy it on its own branch.

Carries the three dependabot commits unchanged and adds the audit
alongside them. Records that the bump does not clear these packages of a
js-yaml advisory: it moves off two HIGH advisories in 4.1.1 onto one in
5.2.1, which is first patched in 5.2.2.

Signed-off-by: Imran Siddique <imran.siddique@opaque.co>
@github-actions github-actions Bot added size/M Medium PR (< 200 lines) documentation Improvements or additions to documentation labels Aug 12, 2026
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@microsoft/agent-governance-sdk 5.0.0 🟢 7.9
Details
CheckScoreReason
Dependency-Update-Tool🟢 10update tool detected
Security-Policy🟢 10security policy file detected
Maintained🟢 1030 commit(s) and 9 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 10all changesets reviewed
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
License🟢 10license file detected
Binary-Artifacts🟢 10no binaries found in the repo
CII-Best-Practices🟢 5badge detected: Passing
Pinned-Dependencies🟢 6dependency not pinned by hash detected -- score normalized to 6
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
SAST🟢 9SAST tool detected but not run on all commits
Branch-Protection🟢 5branch protection is not maximal on development and all release branches
Fuzzing🟢 10project is fuzzed
Packaging🟢 10packaging workflow detected
CI-Tests🟢 1030 out of 30 merged PRs checked by a CI test -- score normalized to 10
Contributors🟢 10project has 17 contributing companies or organizations
Vulnerabilities⚠️ 050 existing vulnerabilities detected
npm/@microsoft/agent-governance-sdk 5.0.0 🟢 7.9
Details
CheckScoreReason
Dependency-Update-Tool🟢 10update tool detected
Security-Policy🟢 10security policy file detected
Maintained🟢 1030 commit(s) and 9 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 10all changesets reviewed
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
License🟢 10license file detected
Binary-Artifacts🟢 10no binaries found in the repo
CII-Best-Practices🟢 5badge detected: Passing
Pinned-Dependencies🟢 6dependency not pinned by hash detected -- score normalized to 6
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
SAST🟢 9SAST tool detected but not run on all commits
Branch-Protection🟢 5branch protection is not maximal on development and all release branches
Fuzzing🟢 10project is fuzzed
Packaging🟢 10packaging workflow detected
CI-Tests🟢 1030 out of 30 merged PRs checked by a CI test -- score normalized to 10
Contributors🟢 10project has 17 contributing companies or organizations
Vulnerabilities⚠️ 050 existing vulnerabilities detected
npm/@microsoft/agent-governance-sdk 5.0.0 🟢 7.9
Details
CheckScoreReason
Dependency-Update-Tool🟢 10update tool detected
Security-Policy🟢 10security policy file detected
Maintained🟢 1030 commit(s) and 9 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 10all changesets reviewed
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
License🟢 10license file detected
Binary-Artifacts🟢 10no binaries found in the repo
CII-Best-Practices🟢 5badge detected: Passing
Pinned-Dependencies🟢 6dependency not pinned by hash detected -- score normalized to 6
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
SAST🟢 9SAST tool detected but not run on all commits
Branch-Protection🟢 5branch protection is not maximal on development and all release branches
Fuzzing🟢 10project is fuzzed
Packaging🟢 10packaging workflow detected
CI-Tests🟢 1030 out of 30 merged PRs checked by a CI test -- score normalized to 10
Contributors🟢 10project has 17 contributing companies or organizations
Vulnerabilities⚠️ 050 existing vulnerabilities detected
npm/@microsoft/agent-governance-sdk 5.0.0 🟢 7.9
Details
CheckScoreReason
Dependency-Update-Tool🟢 10update tool detected
Security-Policy🟢 10security policy file detected
Maintained🟢 1030 commit(s) and 9 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 10all changesets reviewed
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
License🟢 10license file detected
Binary-Artifacts🟢 10no binaries found in the repo
CII-Best-Practices🟢 5badge detected: Passing
Pinned-Dependencies🟢 6dependency not pinned by hash detected -- score normalized to 6
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
SAST🟢 9SAST tool detected but not run on all commits
Branch-Protection🟢 5branch protection is not maximal on development and all release branches
Fuzzing🟢 10project is fuzzed
Packaging🟢 10packaging workflow detected
CI-Tests🟢 1030 out of 30 merged PRs checked by a CI test -- score normalized to 10
Contributors🟢 10project has 17 contributing companies or organizations
Vulnerabilities⚠️ 050 existing vulnerabilities detected

Scanned Files

  • agent-governance-antigravity-cli/package-lock.json
  • agent-governance-claude-code/package-lock.json
  • agent-governance-copilot-cli/package-lock.json
  • agent-governance-copilot-cli/package.json

@github-actions

Copy link
Copy Markdown

PR Review Summary

Check Status Details
🔍 Code Review ⚠️ Missing No current-run comment
🛡️ Security Scan ⚠️ Missing No current-run comment
🔄 Breaking Changes ⚠️ Missing No current-run comment
📝 Docs Sync ⚠️ Missing No current-run comment
🧪 Test Coverage ⚠️ Missing No current-run comment

Verdict: ⚠️ AI review incomplete; ready for human review

AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims.

@github-actions

Copy link
Copy Markdown

📦 Dependency diff (SBOM)

Comparing mainchore/sdk-5-cli-packages.

Summary: ➕ 0 added · ➖ 0 removed · 🔄 3 bumped

🔄 Bumped

npm (3)

Package From To
%40microsoft/agent-governance-antigravity-cli 4.0.0 5.0.0
%40microsoft/agent-governance-claude-code 4.0.0 5.0.0
%40microsoft/agent-governance-copilot-cli 4.0.0 5.0.0

@github-actions

Copy link
Copy Markdown

🔴 Contributor Check: HIGH

Check Result
Profile HIGH
Credential LOW
Overall HIGH

Automated check by AGT Contributor Check.

@github-actions github-actions Bot added the needs-review:HIGH Contributor reputation check flagged HIGH risk label Aug 12, 2026
The audit doc above failed spell-check on fragments of GHSA identifiers
(xmqj, mxrg, fgmg). Advisory IDs are random strings, so adding each one
to the dictionary would grow it by three entries per advisory cited and
would recur on every future security audit doc.

Matching the identifier shape instead fixes the class. Also adds omap,
the YAML ordered-map tag, which is a real term rather than a random one.

Signed-off-by: Imran Siddique <imran.siddique@opaque.co>
#3623 moved the SDK source to js-yaml 5.2.3 earlier today, so the
recommendation to repin was already stale when written. The residual
exposure is in the published 5.0.0 artifact, which pins 5.2.1 and is
immutable, so it closes on the next SDK publish rather than by any change
to these lockfiles.

Signed-off-by: Imran Siddique <imran.siddique@opaque.co>

@prayagupa Prayag (prayagupa) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly consolidates the three semver-major SDK bumps (#3686/#3681/#3683) byte-identical plus the required audit doc; all checks green. Note the carried-forward js-yaml advisory (GHSA-pm4m-ph32-ghv5, patched in 5.2.2) — durable fix is repinning js-yaml in the SDK. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation needs-review:HIGH Contributor reputation check flagged HIGH risk size/M Medium PR (< 200 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants