chore(deps): bump agent-governance-sdk to 5.0.0 in the three CLI packages, with audit - #3721
Open
Imran Siddique (imran-siddique) wants to merge 6 commits into
Open
chore(deps): bump agent-governance-sdk to 5.0.0 in the three CLI packages, with audit#3721Imran Siddique (imran-siddique) wants to merge 6 commits into
Imran Siddique (imran-siddique) wants to merge 6 commits into
Conversation
Bumps [@microsoft/agent-governance-sdk](https://github.com/microsoft/agent-governance-toolkit/tree/HEAD/agent-governance-typescript) from 4.0.0 to 5.0.0. - [Release notes](https://github.com/microsoft/agent-governance-toolkit/releases) - [Changelog](https://github.com/microsoft/agent-governance-toolkit/blob/main/CHANGELOG.md) - [Commits](https://github.com/microsoft/agent-governance-toolkit/commits/v5.0.0/agent-governance-typescript) --- updated-dependencies: - dependency-name: "@microsoft/agent-governance-sdk" dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@microsoft/agent-governance-sdk](https://github.com/microsoft/agent-governance-toolkit/tree/HEAD/agent-governance-typescript) from 4.0.0 to 5.0.0. - [Release notes](https://github.com/microsoft/agent-governance-toolkit/releases) - [Changelog](https://github.com/microsoft/agent-governance-toolkit/blob/main/CHANGELOG.md) - [Commits](https://github.com/microsoft/agent-governance-toolkit/commits/v5.0.0/agent-governance-typescript) --- updated-dependencies: - dependency-name: "@microsoft/agent-governance-sdk" dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@microsoft/agent-governance-sdk](https://github.com/microsoft/agent-governance-toolkit/tree/HEAD/agent-governance-typescript) from 4.0.0 to 5.0.0. - [Release notes](https://github.com/microsoft/agent-governance-toolkit/releases) - [Changelog](https://github.com/microsoft/agent-governance-toolkit/blob/main/CHANGELOG.md) - [Commits](https://github.com/microsoft/agent-governance-toolkit/commits/v5.0.0/agent-governance-typescript) --- updated-dependencies: - dependency-name: "@microsoft/agent-governance-sdk" dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
The vendored-patch-audit gate greps the PR's own diff for the audit doc, and exempts dependabot only for non-major updates, so a semver-major bump opened by dependabot can never satisfy it on its own branch. Carries the three dependabot commits unchanged and adds the audit alongside them. Records that the bump does not clear these packages of a js-yaml advisory: it moves off two HIGH advisories in 4.1.1 onto one in 5.2.1, which is first patched in 5.2.2. Signed-off-by: Imran Siddique <imran.siddique@opaque.co>
Imran Siddique (imran-siddique)
requested review from
MohammadHaroonAbuomar and
liamcrumm
as code owners
August 12, 2026 19:21
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
📦 Dependency diff (SBOM)Comparing main → chore/sdk-5-cli-packages. Summary: ➕ 0 added · ➖ 0 removed · 🔄 3 bumped 🔄 Bumped
|
| Package | From | To |
|---|---|---|
| %40microsoft/agent-governance-antigravity-cli | 4.0.0 | 5.0.0 |
| %40microsoft/agent-governance-claude-code | 4.0.0 | 5.0.0 |
| %40microsoft/agent-governance-copilot-cli | 4.0.0 | 5.0.0 |
|
🔴 Contributor Check: HIGH
Automated check by AGT Contributor Check. |
The audit doc above failed spell-check on fragments of GHSA identifiers (xmqj, mxrg, fgmg). Advisory IDs are random strings, so adding each one to the dictionary would grow it by three entries per advisory cited and would recur on every future security audit doc. Matching the identifier shape instead fixes the class. Also adds omap, the YAML ordered-map tag, which is a real term rather than a random one. Signed-off-by: Imran Siddique <imran.siddique@opaque.co>
This was referenced Aug 12, 2026
#3623 moved the SDK source to js-yaml 5.2.3 earlier today, so the recommendation to repin was already stale when written. The residual exposure is in the published 5.0.0 artifact, which pins 5.2.1 and is immutable, so it closes on the next SDK publish rather than by any change to these lockfiles. Signed-off-by: Imran Siddique <imran.siddique@opaque.co>
Prayag (prayagupa)
approved these changes
Aug 12, 2026
Prayag (prayagupa)
left a comment
Collaborator
There was a problem hiding this comment.
Correctly consolidates the three semver-major SDK bumps (#3686/#3681/#3683) byte-identical plus the required audit doc; all checks green. Note the carried-forward js-yaml advisory (GHSA-pm4m-ph32-ghv5, patched in 5.2.2) — durable fix is repinning js-yaml in the SDK. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates #3686, #3683 and #3681, and adds the dependency audit that unblocks them.
Why they cannot land on their own
scripts/ci/vendored-patch-audit.shexempts Dependabot only for non-major updates:These three run with
DEPENDABOT_UPDATE_TYPE: version-update:semver-major, so the exemption does not apply and the gate requires an audit doc. It looks for that doc in the PR's own diff:Dependabot does not write audit docs, so a semver-major Dependabot PR can never satisfy this gate on its own branch, and a separate doc PR would not satisfy it either. All three have been red on
Dependency Audit Trailsince 2026-08-11 for that reason, not because anything is wrong with them.What this PR contains
The three Dependabot commits cherry-picked unchanged, plus one audit doc. Verified with
git diffagainst each original head:package.jsonandpackage-lock.jsonin all three packages are byte-identical to what Dependabot produced. TheirSigned-off-by: dependabot[bot]trailers are preserved, so authorship and DCO are intact.bash scripts/ci/vendored-patch-audit.sh origin/mainpasses on this branch.The finding worth reading
The audit is not a rubber stamp. This bump does not clear these packages of a
js-yamladvisory.js-yaml4.1.1is in range for two HIGH advisories:GHSA-5p4m-2wfm-xmqj(patched4.3.1) andGHSA-52cp-r559-cp3m(patched4.3.0).js-yaml5.2.1, the SDK's own pin, is in range forGHSA-pm4m-ph32-ghv5, HIGH,>= 5.0.0, <= 5.2.1, first patched in5.2.2. Current release is5.2.3.Two HIGH to one HIGH is the right direction and is not the same as clean. The durable fix is repinning
js-yamlin the SDK rather than overriding it in three CLI lockfiles, so I have not attempted it here. Happy to open that separately if you want it.Otherwise the risk is low. The SDK major is the monorepo-wide v5 version alignment from the
[5.0.0]CHANGELOG entry, not an API break; the published4.0.0and5.0.0manifests agree on every@noble/*pin, onengines.node >=18.0.0and on the license. Each of the three CLI packages already ships at5.0.0while pinning the4.0.0SDK, so this is the first time their published version and their SDK agree.Suggested handling
Close #3686, #3683 and #3681 in favour of this, or tell me you would rather have three separate PRs each carrying its own copy of the doc and I will redo it that way.