feat: multi-chat sessions#213
Open
sandy081 wants to merge 8 commits into
Open
Conversation
…mpl" This reverts commit 58a3fea.
Adds a feature-level walkthrough of multi-chat sessions for reviewers and UX exploration. Lives under docs/proposals (not wired into public nav). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds `interactivity?: "full" | "read-only" | "hidden"` to `ChatSummary` and `ChatState` to support agent-team patterns where worker chats are read-only (visible for observability) or hidden (internal implementation detail). - "full" — user can send messages and watch (default when absent) - "read-only" — user can watch but not send messages - "hidden" — internal worker not shown in UI Harness sets this based on chat role; UI uses it for controls. Example: Claude Code Agent Teams shows all chats with lead interactive, workers read-only. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
connor4312
reviewed
Jun 11, 2026
…eapply # Conflicts: # clients/rust/crates/ahp/src/reducers.rs # clients/swift/AgentHostProtocol/Sources/AgentHostProtocol/Generated/State.generated.swift # clients/swift/CHANGELOG.md
Convert ChatInteractivity from a string-union type alias to a `const enum` (Full/ReadOnly/Hidden) to match the existing style used by ChatOriginKind and other discriminants, per PR review feedback. Update all five client generators to emit it as an enum rather than a string alias, and regenerate clients + schema. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Chats are a subscribable channel (ahp-chat:/<uuid>) as the doc comment already notes, but the Snapshot.state union omitted ChatState, so per-chat snapshots did not type-check.
Commit b88a4a3 added ChatState to the Snapshot.state union in types/ but the per-client generators match the union by exact string, so the new variant fell through to a verbatim `A | B | ...` emission and broke Rust generation. Register the new union string in all four generators and regenerate the schema (now includes ChatState in the snapshot oneOf). The hand-written SnapshotState enums already carry a Chat variant, so generated client sources are unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies the multi-chat work from #197, which was accidentally merged and then reverted in #212. This restores the exact tree of the original PR head (
b55919a); diff vs that commit is empty.Summary
types/) and all clients (Rust/Kotlin/Swift/TypeScript/Go).createChat/disposeChat; session actionsSessionChatAdded/SessionChatRemoved/SessionChatUpdated/DefaultChatChanged.SessionState.chats: ChatSummary[]+defaultChat?; breaking removal ofSessionState.turns/activeTurn.b55919a.Why a new PR
#197 cannot be reopened (its branch was merged then reverted). This PR re-applies the work via revert-of-revert.
Gate
Per @connor4312, hold merge until the VS Code adoption PR is ready.