Mark Aspire.EndToEnd.Tests as outerloop#15182
Merged
radical merged 5 commits intorelease/13.2from Mar 12, 2026
Merged
Conversation
Copilot created this pull request from a session on behalf of
radical
March 12, 2026 18:48
View session
Member
|
@copilot also use the 8-core Ubuntu-latest runner for Aspire.endtoend.tests |
Contributor
Author
eerhardt
reviewed
Mar 12, 2026
|
|
||
| using Aspire.TestUtilities; | ||
|
|
||
| [assembly: OuterloopTest("EndToEnd tests require Docker and are slow")] |
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15182Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15182" |
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #23026886659 |
Contributor
|
The transient CI rerun workflow requested reruns for the following jobs after analyzing the failed attempt.
|
radical
force-pushed
the
copilot/mark-aspire-e2e-tests-outerloop
branch
from
bd20ad0 to
91af188
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
radical
force-pushed
the
copilot/mark-aspire-e2e-tests-outerloop
branch
from
91af188 to
07e02a8
Compare
radical
added
the
NO-MERGE
JamesNK
approved these changes
Mar 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Moves Aspire.EndToEnd.Tests into the outerloop testing lane (Docker-dependent/slow tests) and updates the specialized test workflow plumbing to support new per-test requirements and runner selection.
Changes:
- Mark
Aspire.EndToEnd.Testsas outerloop and skip it on GitHub Actions unless outerloop is explicitly enabled. - Enhance specialized test runsheet generation/workflow to support a new
requiresCliArchivecapability. - Allow test projects to override the GitHub Actions runner label (e.g., use an 8-core Linux runner).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.EndToEnd.Tests/IntegrationServicesTests.cs | Adds outerloop annotations to indicate Docker/slow E2E tests. |
| tests/Aspire.EndToEnd.Tests/AssemblyInfo.cs | Marks the entire test assembly as outerloop. |
| tests/Aspire.EndToEnd.Tests/Aspire.EndToEnd.Tests.csproj | Skips tests on GHA unless outerloop is enabled; requests a larger Linux runner. |
| tests/Aspire.Cli.EndToEnd.Tests/Aspire.Cli.EndToEnd.Tests.csproj | Skips CLI E2E tests on GHA except for PRs. |
| eng/Testing.targets | Moves IsGitHubActionsRunner detection out of Testing.targets. |
| eng/Testing.props | Adds IsGitHubActionsRunner detection in props (import earlier in build). |
| eng/SpecializedTestRunsheetBuilderBase.targets | Adds requiresCliArchive + runner overrides; changes how “requiresNugets/TestSdk” are determined. |
| .github/workflows/specialized-test-runner.yml | Plumbs requiresCliArchive through matrix generation and triggers CLI archive build only when needed. |
Comment on lines
12
to
+15
| <IsGithubPullRequest Condition="'$(GITHUB_EVENT_NAME)' == 'pull_request'">true</IsGithubPullRequest> | ||
|
|
||
| <!-- See https://docs.github.com/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables --> | ||
| <IsGitHubActionsRunner Condition="'$(GITHUB_ACTIONS)' == 'true'">true</IsGitHubActionsRunner> |
There was a problem hiding this comment.
MSBuild property naming is inconsistent (IsGithubPullRequest vs IsGitHubActionsRunner). Since these properties are consumed across projects/targets, inconsistent casing makes it harder to discover/remember the correct property name and increases the chance of typos. Consider standardizing on a single convention (e.g., IsGitHub*) and (if needed for compatibility) providing an alias property so both spellings resolve to the same value.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
radical
removed
the
NO-MERGE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
Aspire.EndToEnd.Teststo Outerloop tests workflow. The other changes are to enable that to work correctly.