Skip to content

[IGNORE] Running Cli E2E tests with 13.2#15414

Draft
radical wants to merge 1 commit intomicrosoft:release/13.2from
radical:cli-e2e-alternate-location
Draft

[IGNORE] Running Cli E2E tests with 13.2#15414
radical wants to merge 1 commit intomicrosoft:release/13.2from
radical:cli-e2e-alternate-location

Conversation

@radical
Copy link
Member

@radical radical commented Mar 19, 2026

  • All install methods now use --install-path to install to temp directories
  • Docker tests use /tmp/aspire-install (ephemeral container)
  • Non-Docker tests use C#-generated unique paths via Guid
  • rm -rf ~/.aspire before each install for clean environment
  • Added SetupAspireCliFromPullRequestAsync/SetupAspireBundleFromPullRequestAsync composite helpers that handle install, PATH setup, and version verification
  • InstallAspireCliVersionAsync now handles PATH setup internally
  • Old individual Install/Source methods made private with installPath parameter
  • Simplified callers in all 4 non-Docker test files

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15414

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15414"

@radical radical force-pushed the cli-e2e-alternate-location branch 2 times, most recently from 936110b to 61f2cf1 Compare March 20, 2026 00:31
@github-actions
Copy link
Contributor

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

@radical radical closed this Mar 20, 2026
@radical radical reopened this Mar 20, 2026
@dotnet-policy-service dotnet-policy-service bot added this to the 13.2 milestone Mar 20, 2026
- Install aspire CLI to temporary paths instead of ~/.aspire default
  - Docker tests: /tmp/aspire-install
  - Non-Docker tests: unique GUID-based temp dirs
- Clear ~/.aspire/bin before installs to avoid stale defaults
- Echo 'which aspire' and 'aspire --version' after PATH setup
- Support env var overrides:
  - ASPIRE_CLI_USE_SYSTEM=true: skip install, use system aspire
  - ASPIRE_CLI_INSTALL_SCRIPT: choose get-aspire-cli or get-aspire-cli-pr
  - ASPIRE_CLI_INSTALL_ARGS: extra args passed to the script
- Staging channel support:
  - Enable features.stagingChannelEnabled and set channel globally
  - Set channel locally for TypeScript apphosts (no NuGet.config)
- Handle version selector presence/absence (AcceptVersionSelectionIfShownAsync)
  - Works with hives (version selector shown) and without (auto-select)
- CI workflow uses get-aspire-cli with -q staging quality

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@radical radical force-pushed the cli-e2e-alternate-location branch from 61f2cf1 to 928335f Compare March 20, 2026 03:18
@github-actions
Copy link
Contributor

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant