Add Windows CLI starter validation#15446
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15446Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15446" |
There was a problem hiding this comment.
Pull request overview
Adds a new Windows PR-only GitHub Actions job to dogfood the Aspire CLI produced by the current workflow run, generate starter templates, run aspire start, and validate expected resources reach a healthy running state.
Changes:
- Introduces
cli_starter_validation_winjob that installs the PR-built CLI viaget-aspire-cli-pr.ps1, creates two starter projects, starts them, and pollsaspire resourcesfor readiness. - Collects and uploads diagnostic logs/artifacts for troubleshooting.
- Updates the final
resultsgate to include the new validation job.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Regarding the Copilot overview review: thanks for the summary. This one is informational rather than actionable feedback, so I did not make an additional code change for it. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…Copilot@users.noreply.github.com>
…19+Copilot@users.noreply.github.com>
…6219+Copilot@users.noreply.github.com>
…6219+Copilot@users.noreply.github.com>
…3556219+Copilot@users.noreply.github.com>
|
closing and reopening to trigger CI. |
|
🎬 CLI E2E Test Recordings — 54 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23385918629 |
| with: | ||
| versionOverrideArg: ${{ inputs.versionOverrideArg }} | ||
|
|
||
| cli_starter_validation_win: |
There was a problem hiding this comment.
NIT: to follow precedent as well as make this file easier to parse, can we split the actual implementation of the validation to a separate file that gets ipmorted here?
| // If not trusted at all, run the trust operation | ||
| if (trustResult.IsNotTrusted) | ||
| { | ||
| if (_isWindows() && !hostEnvironment.SupportsInteractiveInput) |
There was a problem hiding this comment.
While I understand the motivation here, I can't help but feel that this is probably kind of custom. Also, IIUC this would make it where it would be impossible to turrn this on in GitHub actions, Azure pipelines, jenkins etc, which while it is probably a good default, it means that if someone for whatever reason does want to prompt for trust it is not possible.
Totally ok to push back, but what do you think about having an env variable that we check instead that only controls this particular behavior, so something like: ASPIRE_SKIP_CERTIFICATE_TRUST or something along those lines? Again, totally ok if you think this is better, just curious to hear your thoughts.
Description
Adds a new Windows PR CI validation for the Aspire CLI in
tests.ymlthat dogfoods the CLI from the current PR artifacts, creates starter templates, runsaspire start, and verifies the expected resources come up.This runs alongside the existing PR dogfood flow by downloading
eng/scripts/get-aspire-cli-pr.ps1from the PR head SHA and passing the current workflow run ID so the job can install the CLI built by the same CI run. The validation now covers both the Express/React starter (aspire-ts-starter) and the C# starter equivalent on this branch (aspire-starter).Validation:
.github/workflows/tests.ymlsuccessfully with Ruby YAML parsing.--outputin non-interactive mode.aspire startdisposed-service-provider failure outside the workflow wiring.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: