Tighten Kusto emulator functional log assertions#15473
Open
sebastienros wants to merge 13 commits intomainfrom
Open
Tighten Kusto emulator functional log assertions#15473sebastienros wants to merge 13 commits intomainfrom
sebastienros wants to merge 13 commits intomainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15473Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15473" |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Narrows Kusto emulator functional test log assertions so they only validate database creation failures, avoiding unrelated stderr/log noise during emulator startup.
Changes:
- Update duplicate-database test to assert no “Failed to create database” resource log is emitted.
- Update invalid-database test to assert exactly one database-creation failure log is emitted and references
__invalid. - Add a shared
IsDatabaseCreationFailureLogpredicate to scope log filtering to the intended signal.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
radical
approved these changes
Mar 21, 2026
Member
|
retrying tests |
Contributor
|
🎬 CLI E2E Test Recordings — 52 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23415234643 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These Kusto functional tests started failing on
mainbecause they were asserting over every warning/error resource log captured during emulator startup. Recent emulator stderr noise (for example theQueryPlanner/QueryRuntimemessages) made those assertions too broad and obscured the actual behaviors the tests are meant to verify.This change narrows both tests to the specific signal they care about: database creation failures. The duplicate-database test now verifies that no
Failed to create databaselog is emitted, and the invalid-database test now verifies that exactly one database creation failure is logged and that it is for__invalid.No product code changed; this is a targeted functional test stabilization for the Kusto emulator logging behavior.
Fixes #15463
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: