Skip to content

fix(agentchat): respect allow_repeated_speaker=False in selector fallback #7568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
extrasmall0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(agentchat): respect allow_repeated_speaker=False in selector fallback #7568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...ackages/autogen-agentchat/src/autogen_agentchat/teams/_group_chat/_selector_group_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,15 @@ async def _select_speaker(self, roles: str, participants: List[str], max_attempt
trace_logger.debug(f"Model selected a valid name: {agent_name} (attempt {num_attempts})")
return agent_name

if self._previous_speaker is not None and not self._allow_repeated_speaker:
# Repeated speaker is not allowed; pick randomly from the already-filtered
# participants list (which already excludes the previous speaker).
trace_logger.warning(
f"Model failed to select a speaker after {max_attempts}, "
f"falling back to a random participant (excluding previous speaker '{self._previous_speaker}')."
)
import random
return random.choice(participants)
if self._previous_speaker is not None:
trace_logger.warning(f"Model failed to select a speaker after {max_attempts}, using the previous speaker.")
return self._previous_speaker
Expand Down