Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Add option --baseurl to override default endpoint#55

Open
iwinux wants to merge 1 commit intomicrosoft:masterfrom
iwinux:master
Open

Add option --baseurl to override default endpoint#55
iwinux wants to merge 1 commit intomicrosoft:masterfrom
iwinux:master

Conversation

@iwinux
Copy link
Copy Markdown

@iwinux iwinux commented Nov 18, 2018

related issue: #43

Copy link
Copy Markdown

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except comment.

Comment thread vhdUploadCmdHandler.go
"github.com/Microsoft/azure-vhd-utils/vhdcore/diskstream"
"github.com/Microsoft/azure-vhd-utils/vhdcore/validator"
"gopkg.in/urfave/cli.v1"
cli "gopkg.in/urfave/cli.v1"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? It should be usable under just v1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants