Add ignition 2.25.1 to core repo in azure linux #15516
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Packaging
specs-extended
Contributor
Contributor
Author
Buddy Build has passed. |
SumitJenaHCL
force-pushed
the
topic_ignition
branch
from
e25be60 to
cfedc75
Compare
Contributor
sandeepkarambelkar
requested changes
Jan 21, 2026
| %if %{with check} | ||
| %check | ||
| sed -i '34d' ./test | ||
| VERSION=%{version} GOARCH=amd64 ./test |
Contributor
There was a problem hiding this comment.
Please don't hardcode the architecture here but it should be taken from the build arguments %{_target_cpu}.
|
|
||
| %global gocrossbuild go build -ldflags "${LDFLAGS:-} -B 0x$(cat /dev/urandom | tr -d -c '0-9a-f' | head -c16)" -a -v -x | ||
|
|
||
| %if 0%{?fedora} |
Contributor
There was a problem hiding this comment.
We don't need this check. Its better if we build and release validate binary in AzureLinux. We have validate rpm getting built. So this condition is not required.
|
|
||
| %if 0%{?fedora} | ||
| echo "Building statically-linked Linux ignition-validate..." | ||
| GOEXPERIMENT= CGO_ENABLED=0 GOARCH=arm64 GOOS=linux %gocrossbuild -o ./ignition-validate-aarch64-unknown-linux-gnu-static validate/main.go |
Contributor
There was a problem hiding this comment.
Lets build the binary for the architecture for which build is in progress. You can get the target architecture using %{_target_cpu}
Contributor
Contributor
sandeepkarambelkar
requested changes
Jan 22, 2026
Added a newline at the end of the file to comply with formatting standards.
Removed conditional builds for various architectures and platforms in the ignition.spec file.
SumitJenaHCL
force-pushed
the
topic_ignition
branch
from
e2d5698 to
3ebaff4
Compare
12 tasks
sandeepkarambelkar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
This PR is to add package ignition to SPECS.
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology