feat(kernel): Enable USB_NET_RNDIS_HOST - #18226
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Enables x86_64 USB RNDIS host support while incorporating the preceding kernel configuration changes in the linked PR series.
Changes:
- Enables RNDIS networking and related USB networking modules.
- Includes prior GHES and Broadcom RoCE configuration updates.
- Advances the package release and refreshes policy, lock, and rendered files.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/kernel/6.18-x86_64-azl.config |
Updates x86_64 kernel configuration. |
base/comps/kernel/kernel.azl.macros |
Advances package release to 12. |
base/comps/kernel/kernel.spec |
Adds changelog entries for the series. |
locks/kernel.lock |
Refreshes the component input fingerprint. |
scripts/ci/kernel/kernel-config-checker/kernel_config_checker/kernel_configs_json/azl4-os-required-kernel-configs.json |
Updates required kernel configuration policy. |
specs/k/kernel/6.18-x86_64-azl.config |
Mirrors the rendered kernel configuration. |
specs/k/kernel/kernel.azl.macros |
Mirrors the rendered release macro. |
specs/k/kernel/kernel.spec |
Mirrors the rendered changelog. |
| # CONFIG_USB_VL600 is not set | ||
| # CONFIG_USB_NET_CH9200 is not set | ||
| # CONFIG_USB_NET_AQC111 is not set | ||
| CONFIG_USB_RTL8153_ECM=m |
There was a problem hiding this comment.
This is a false positive. USB_NET_RNDIS_HOST[1] selects USB_NET_CDCETHER[2], which makes USB_RTL8153_ECM[3] available.
Since USB_RTL8153_ECM is tristate with no prompt, users cannot directly set its value. And since it also has default y, the value is automatically selected to the highest value allowed by its dependencies, which USB_NET_CDCETHER && (USB_RTL8152 || USB_RTL8152=n) ends up selecting =m.
ab9efa6 to
77b6414
Compare
|
Thanks Christopher Co (@christopherco), rebased! |
Enable CONFIG_USB_NET_RNDIS_HOST=m in the AzL4 x86_64 kernel config. This pulls in the required USB usbnet chain (USB_NET_DRIVERS=m, USB_USBNET=m, USB_NET_CDCETHER=m, which RNDIS_HOST selects). All other USB net drivers are explicitly kept disabled for minimal divergence; USB_RTL8153_ECM is a non-prompt helper forced on by CDCETHER. Bump %azl_pkgrelease 15 -> 16 and add changelog entry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: beb7925d-4db5-464b-9a33-0fa9f3179e95
77b6414 to
53bb473
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (1)
base/comps/kernel/6.18-x86_64-azl.config:3623
- This also enables the unrelated RTL8153 ECM driver.
USB_NET_RNDIS_HOSTselectsUSB_NET_CDCETHER, but it does not selectUSB_RTL8153_ECM, whose Kconfig entry has no default. Leaving this asmexpands the shipped driver set beyond the stated RNDIS change; keep it disabled, then re-render the generated config and refresh the lock.
CONFIG_USB_RTL8153_ECM=m
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
0d915c2
into
microsoft:4.0
Enable USB_NET_RNDIS_HOST
This is a series of PRs, look at
#17874
#18224