feat(images): add 1p-vm-base-gen1-fips image - #18469
Closed
binujp wants to merge 1 commit into
Closed
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot stopped reviewing on behalf of
binujp due to an error
August 17, 2026 15:54
Dan Streetman (ddstreetmicrosoft)
requested changes
Aug 17, 2026
Dan Streetman (ddstreetmicrosoft)
left a comment
There was a problem hiding this comment.
issue(blocking): I have the same concerns here as in the other PR: #18468 (review)
Add the Azure Linux 4.0 1P VM Base Gen1 FIPS (BIOS) image. It matches the Gen1 base image with FIPS enabled through `fips=1` on the kernel command line and the dracut-fips module. Legacy BIOS boot uses a GPT hybrid (eficsm) disk. The image relies on package-provided cloud-init, chrony/PTP, and Hyper-V configuration, with no KIWI file injection or config.sh post-install customization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 727c4c35-afde-4eb0-82bf-b307f6550d58
binujp
force-pushed
the
bphilip/add-marketplace-gen1-fips
branch
from
August 17, 2026 20:23
0a27e35 to
b92b628
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Suppressed comments (4)
base/images/1p-vm-base-gen1-fips/1p-vm-base-gen1-fips.kiwi:41
- Local image builds should use the azl4-dev blob, while the installed
azurelinux-repospackage controls the runtime PMC-beta source. Every existing KIWI definition follows this split (for example,base/images/vm-base/vm-base.kiwi:83-92), andbase/images/images.toml:21-23documents that Koji overrides the build repository. Pointing the build directly at PMC beta makes local validation consume stale published packages rather than current distro inputs.
<source path="https://packages.microsoft.com/azurelinux/4.0/beta/base/$basearch" />
base/images/images.toml:100
- This package-managed image is missing the required canonical/
-devpair documented atbase/images/images.toml:5-27; all existing non-distroless images use profiles to selectazurelinux-reposversusazurelinux-repos-dev. Add a1p-vm-base-gen1-fips-devregistry entry and matching KIWI profiles/package sections so development builds do not boot with production repository configuration.
[images.1p-vm-base-gen1-fips]
description = "1P VM Base Gen1 FIPS Image (BIOS)"
definition = { type = "kiwi", path = "1p-vm-base-gen1-fips/1p-vm-base-gen1-fips.kiwi" }
base/images/1p-vm-base-gen1-fips/1p-vm-base-gen1-fips.kiwi:130
- Remove the unmatched closing parenthesis in this comment.
<!-- Hyper-V via kernel-modules + hyperv-daemons) -->
base/images/images.toml:103
- Only offline filesystem checks are registered, so the reported image test cannot verify the two defining runtime behaviors: booting as an Azure Gen1 VM and entering FIPS mode. The comparable
vm-baseentry registers LISA boot suites (base/images/images.toml:35-42). Add an appropriate boot/runtime suite and a FIPS assertion (for example, checking/proc/sys/crypto/fips_enabled) before relying on this image.
tests.test-suites = [
{ name = "static-image-checks" },
]
| filesystem="ext4" | ||
| fscreateoptions="-m 1" | ||
| kernelcmdline="console=ttyS0 fips=1" | ||
| firmware="uefi" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
azldev image build 1p-vm-base-gen1-fips --arch x86_64azldev image test 1p-vm-base-gen1-fips(9 passed, 7 skipped)AB#22819