feat(rust-ctutils): add rust-ctutils component - #18472
Draft
Autumn Nash (WithEnoughCoffee) wants to merge 1 commit into
Draft
feat(rust-ctutils): add rust-ctutils component#18472Autumn Nash (WithEnoughCoffee) wants to merge 1 commit into
Autumn Nash (WithEnoughCoffee) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Autumn Nash (WithEnoughCoffee)
August 17, 2026 19:15
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the pinned Fedora 43 rust-ctutils component required by the RustCrypto dependency chain.
Changes:
- Adds component configuration with
%checkdisabled pending proptest 1.11. - Adds lock and rendered RPM packaging files for version 0.4.2.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/rust-ctutils/rust-ctutils.comp.toml |
Defines the pinned component and build configuration. |
locks/rust-ctutils.lock |
Locks upstream resolution and inputs. |
specs/r/rust-ctutils/rust-ctutils.spec |
Provides the rendered RPM specification. |
specs/r/rust-ctutils/rust-ctutils.azl.macros |
Disables %check in the rendered build. |
specs/r/rust-ctutils/sources |
Records the crate source checksum. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Split out of #18405 so it can be built and tagged in koji first -- rust-ctutils has a real BuildRequires on rust-cmov, which koji's scratch-build gate can't resolve against an untagged sibling package in the same PR. Needed transitively via rust-digest's new 'mac' feature for rust-hmac 0.13.0. %check disabled pending the proptest bump landing in #18405.
Autumn Nash (WithEnoughCoffee)
force-pushed
the
fix/rust-ctutils-uv-buildreq
branch
from
August 17, 2026 21:16
2d0b3de to
e70984d
Compare
Copilot started reviewing on behalf of
Autumn Nash (WithEnoughCoffee)
August 17, 2026 21:18
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
base/comps/rust-ctutils/rust-ctutils.comp.toml:17
- Disabling the bcond only through
withoutomits the required structured%checkjustification, so check-disablement tooling cannot audit this temporary exception. Keep the bcond override because it prevents%cargo_generate_buildrequiresfrom resolving the unavailable proptest dependency, but also record the skip and re-enable condition throughbuild.check.
without = ["check"]
Contributor
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New leaf Rust crate component,
rust-ctutils, split out of #18405 (zip-prereqs) specifically so it can be built and tagged into the koji build repo before that PR, following the same pattern asrust-cpubits(#18446) andrust-cmov(#18445).Why this needs to be its own PR
Koji scratch builds only resolve dynamic BuildRequires (
%cargo_generate_buildrequires) against already-tagged packages in the target repo.rust-ctutilsis "Built on thecmovcrate" — a real, dynamically-resolved BuildRequires — so it cannot build in the same PR as an untaggedrust-cmov. This is identical to whyrust-cpubitswas split out forrust-aes0.9.1'scrate(cpubits/default)requirement.rust-ctutils0.4.2 is a brand-new package (not previously in AZL), needed transitively viarust-digest's new "mac" feature subpackage (crate(ctutils/default) >= 0.4.0, < 0.5.0), whichrust-hmac0.13.0 requires as part of #18405's uv crate-alignment cascade.%checkdisabledrust-ctutils's test suite requirescrate(proptest/default) >= 1.11.0, which is itself being bumped in #18405 in the same wave — a same-PR interdependent new-package BuildRequires that koji's scratch-build gate can never resolve.%checkis disabled for now; revisit once the proptest bump has merged/tagged.Verification
azldev comp build --local-repo-with-publish -p rust-cmov -p rust-ctutils) usingrust-cmovfrom feat(rust-cmov): add rust-cmov component #18445's branch — succeeded, confirming the real dependency resolves oncecmovis tagged.cmov→cpubits→ctutils→ all 18 zip-prereqs components) verified together end-to-end — all succeed,%checkpassing where enabled.rpm -qlpinspection: source-registry files only (/usr/share/cargo/registry/ctutils-0.4.2/...), no binaries — this is a cargo "source crate" style devel package, so no smoke-test beyond content inspection applies (consistent with therust-cpubitsprecedent).azldev comp render -p rust-ctutilsis idempotent (changed=false).azldev comp update -p rust-ctutilsclean, no lock drift.Sequencing
Depends on
rust-cmov(#18445) merging/tagging first. Once merged,#18405(zip-prereqs) and its follow-ons can resolvecrate(ctutils/default)dynamically at build time.