Conversation
Collaborator
|
@bdrodes third time's the charm! See the latest backlink in this PR for the DCA run. |
…hey were there, but too confusing to have repeating tests.
MathiasVP
reviewed
Dec 5, 2025
Collaborator
MathiasVP
left a comment
There was a problem hiding this comment.
One question, but otherwise this LGTM!
cpp/ql/src/Microsoft/Likely Bugs/SizeOfMisuse/SizeOfConstIntMacro.ql
Outdated
Show resolved
Hide resolved
…cro.ql Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
MathiasVP
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications to two sizeof queries:
This involved adding additional filters to how sizeof operations are chosen, which largely focused on filtering patterns observed in linux, and common patterns for asserts.
Additional filters were added to address false positives in evaluating const-int-argument for MORSE. Auditing for const-int-argument was completed over 50 cases for MORSE.
Some general stats:
Note, we previously considered the existing FPs acceptable as they were highly concentrated in macros that were repeatedly used. The use was suspect, though correct. Given how popular the specific macros were, we have now decided to filter these cases out to avoid noise.