Keep Compose image links local when Docker is present#198
Open
kiwigitops wants to merge 1 commit into
Open
Conversation
Author
|
Quick follow-up on this. The local Compose image link handling is still current, and I am happy to adjust the Docker-present behavior or test coverage if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #179.
When the Docker extension is present, this client capability currently tells the Compose language service to stop providing image links. That hands image refs to Docker's provider, which can turn private registry refs into Docker Hub URLs.
This keeps Compose's own image link provider active so it keeps using the stricter registry handling already in this package.
Checked with
git diff --checkusing the repo's CRLF-aware whitespace settings. I did not run the mocha suite locally because this fresh checkout does not have the Node dependencies installed.