Skip to content

refactor: remove GitHub panic error reporter - #400

Open
Sheng Chen (jdneo) wants to merge 1 commit into
mainfrom
jdneo-remove-github-panic-report
Open

refactor: remove GitHub panic error reporter#400
Sheng Chen (jdneo) wants to merge 1 commit into
mainfrom
jdneo-remove-github-panic-report

Conversation

@jdneo

@jdneo Sheng Chen (jdneo) commented Aug 6, 2026

Copy link
Copy Markdown
Member

We never use/observe this reporter, remove it.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jdneo
Sheng Chen (jdneo) marked this pull request as ready for review August 7, 2026 05:37
Copilot AI lite review requested due to automatic review settings August 7, 2026 05:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the legacy “GitHub panic” error reporter path and relocates the only remaining helper (computeFileName) into the telemetry DTO, keeping exception telemetry generation self-contained in the LSP protocol layer.

Changes:

  • Removed GithubPanicErrorReport and all wiring from CopilotCore and proxy/settings sync.
  • Moved filename derivation logic into TelemetryExceptionParams and improved handling for missing source filenames.
  • Added unit tests to validate telemetry filename derivation behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/LanguageServerSettingManager.java Stops updating the removed panic reporter on proxy/settings changes.
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/protocol/TelemetryExceptionParams.java Inlines filename computation and removes dependency on the deleted reporter.
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/logger/GithubPanicErrorReport.java Deletes the legacy panic error reporter implementation.
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/CopilotCore.java Removes reporter lifecycle/fallback usage from exception reporting.
com.microsoft.copilot.eclipse.core.test/src/com/microsoft/copilot/eclipse/core/lsp/protocol/TelemetryExceptionParamsTests.java Adds coverage for filename computation in telemetry payloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants