refactor: remove GitHub panic error reporter - #400
Open
Sheng Chen (jdneo) wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sheng Chen (jdneo)
marked this pull request as ready for review
August 7, 2026 05:37
Sheng Chen (jdneo)
requested review from
Ethan Hou (ethanyhou) and
xinyi-gong
as code owners
August 7, 2026 05:37
Sheng Chen (jdneo)
requested a review
from Zidong Lu (duzitong)
as a code owner
August 7, 2026 05:37
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacy “GitHub panic” error reporter path and relocates the only remaining helper (computeFileName) into the telemetry DTO, keeping exception telemetry generation self-contained in the LSP protocol layer.
Changes:
- Removed
GithubPanicErrorReportand all wiring fromCopilotCoreand proxy/settings sync. - Moved filename derivation logic into
TelemetryExceptionParamsand improved handling for missing source filenames. - Added unit tests to validate telemetry filename derivation behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/LanguageServerSettingManager.java | Stops updating the removed panic reporter on proxy/settings changes. |
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/protocol/TelemetryExceptionParams.java | Inlines filename computation and removes dependency on the deleted reporter. |
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/logger/GithubPanicErrorReport.java | Deletes the legacy panic error reporter implementation. |
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/CopilotCore.java | Removes reporter lifecycle/fallback usage from exception reporting. |
| com.microsoft.copilot.eclipse.core.test/src/com/microsoft/copilot/eclipse/core/lsp/protocol/TelemetryExceptionParamsTests.java | Adds coverage for filename computation in telemetry payloads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We never use/observe this reporter, remove it.