Skip to content

Dashboard team filters fix, include non-team members if copilot seat allocated to non team members#66

Open
sandeep0402 wants to merge 15 commits into
microsoft:mainfrom
sandeep0402:fix-teams-filters
Open

Dashboard team filters fix, include non-team members if copilot seat allocated to non team members#66
sandeep0402 wants to merge 15 commits into
microsoft:mainfrom
sandeep0402:fix-teams-filters

Conversation

@sandeep0402
Copy link
Copy Markdown

@sandeep0402 sandeep0402 commented Jul 19, 2025

This PR introduces several key improvements and bug fixes to the Copilot Dashboard project:

Team Filters for Dashboard Filtering
Implemented dynamic filtering of dashboard data based on selected team filters, improving data segmentation and usability.

Parent and Child Team Seat Counting
Enhanced seat count logic to accurately include both parent and child teams, ensuring correct usage tracking and reporting.

Seats Page – Runtime Display of Names
Updated the "Check Name" button on the Seats page to display the name dynamically at runtime, improving interactivity and reducing confusion.
image
image

@sandeep0402
Copy link
Copy Markdown
Author

sandeep0402 commented Jul 19, 2025

@microsoft-github-policy-service agree

@Frank802 Frank802 requested a review from Copilot July 22, 2025 10:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements comprehensive team filtering functionality for the Copilot Dashboard, addressing scenarios where Copilot seats are allocated to users who are not members of the teams selected in filters. The main enhancement includes fallback logic to use GitHub Teams API when seat assignment data doesn't contain team information.

  • Enhanced team filtering with hierarchical support and fallback to GitHub Teams API
  • Added runtime name fetching functionality to the Seats page with interactive "Check Name" button
  • Improved stats calculation to use seat data instead of metrics data for active user counts

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/dashboard/services/copilot-seat-service.ts Implements comprehensive team filtering with GitHub Teams API fallback and hierarchical team support
src/dashboard/services/copilot-metrics-service.ts Adds consistent async/await pattern and fixes syntax error
src/dashboard/features/seats/seats-list.tsx Adds interactive name fetching component for user display names
src/dashboard/features/dashboard/filter/header-filter.tsx Conditionally renders team filter only when teams are available
src/dashboard/features/dashboard/filter/dropdown-filter.tsx Fixes dropdown selection callback to properly pass option value
src/dashboard/features/dashboard/charts/stats.tsx Updates active users calculation to use seat data
src/dashboard/features/dashboard/charts/common.ts Adds new function to compute active users from seats data

Comment thread src/dashboard/services/copilot-seat-service.ts Outdated
Comment thread src/dashboard/services/copilot-seat-service.ts Outdated
Comment thread src/dashboard/services/copilot-seat-service.ts Outdated
Comment thread src/dashboard/features/dashboard/charts/common.ts Outdated
Comment thread src/dashboard/features/seats/seats-list.tsx Outdated
Comment thread src/dashboard/services/copilot-seat-service.ts Outdated
@sandeep0402
Copy link
Copy Markdown
Author

@Frank802 Review comments are fixed, Please check once

@Frank802
Copy link
Copy Markdown
Collaborator

Frank802 commented Jul 29, 2025

@sandeep0402 We’ve reviewed the changes you made to how teams are listed, and relying solely on the APIs doesn’t make any sense in this case. What matters most is filtering data from the Copilot Metrics APIs and User Assignment APIs. If no teams are associated with that data, then retrieving a list of teams is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants