Dashboard team filters fix, include non-team members if copilot seat allocated to non team members#66
Dashboard team filters fix, include non-team members if copilot seat allocated to non team members#66sandeep0402 wants to merge 15 commits into
Conversation
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive team filtering functionality for the Copilot Dashboard, addressing scenarios where Copilot seats are allocated to users who are not members of the teams selected in filters. The main enhancement includes fallback logic to use GitHub Teams API when seat assignment data doesn't contain team information.
- Enhanced team filtering with hierarchical support and fallback to GitHub Teams API
- Added runtime name fetching functionality to the Seats page with interactive "Check Name" button
- Improved stats calculation to use seat data instead of metrics data for active user counts
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/dashboard/services/copilot-seat-service.ts | Implements comprehensive team filtering with GitHub Teams API fallback and hierarchical team support |
| src/dashboard/services/copilot-metrics-service.ts | Adds consistent async/await pattern and fixes syntax error |
| src/dashboard/features/seats/seats-list.tsx | Adds interactive name fetching component for user display names |
| src/dashboard/features/dashboard/filter/header-filter.tsx | Conditionally renders team filter only when teams are available |
| src/dashboard/features/dashboard/filter/dropdown-filter.tsx | Fixes dropdown selection callback to properly pass option value |
| src/dashboard/features/dashboard/charts/stats.tsx | Updates active users calculation to use seat data |
| src/dashboard/features/dashboard/charts/common.ts | Adds new function to compute active users from seats data |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t to use computeActiveUserAverage
|
@Frank802 Review comments are fixed, Please check once |
|
@sandeep0402 We’ve reviewed the changes you made to how teams are listed, and relying solely on the APIs doesn’t make any sense in this case. What matters most is filtering data from the Copilot Metrics APIs and User Assignment APIs. If no teams are associated with that data, then retrieving a list of teams is not needed. |
…s; rollback changes for filterSeatsByTeam and related functions.
This PR introduces several key improvements and bug fixes to the Copilot Dashboard project:
Team Filters for Dashboard Filtering
Implemented dynamic filtering of dashboard data based on selected team filters, improving data segmentation and usability.
Parent and Child Team Seat Counting
Enhanced seat count logic to accurately include both parent and child teams, ensuring correct usage tracking and reporting.
Seats Page – Runtime Display of Names


Updated the "Check Name" button on the Seats page to display the name dynamically at runtime, improving interactivity and reducing confusion.