Add LTCG flags to compile_windows.bat for BinSkim BA6006 compliance #1991
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Windows DLL/EXE builds were failing BinSkim BA6006 checks and emitting MSVC linker warnings about
/LTCG specified but no code generation required. Root cause: objects weren't compiled with/GL(whole-program optimization) before linking with/LTCG.Changes
Added LTCG flags to all 6 build commands in
compile_windows.bat:/GLflag to enable whole-program optimization/LTCGflag to enable link-time code generationAffected binaries:
attach_x86.dll/attach_amd64.dllrun_code_on_dllmain_x86.dll/run_code_on_dllmain_amd64.dllinject_dll_x86.exe/inject_dll_amd64.exeBefore:
After:
This ensures each object passed to a
/LTCGlink step was compiled with/GL, satisfying both MSVC requirements and BinSkim security checks.Original prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.