Fix tunnel creation ID conflict handling #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plequere-ms
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a tunnel, the C# and TypeScript SDKs may auto-generate a tunnel ID, but then incorrectly handle the error condition when the generated ID conflicts with an existing tunnel. The main impact was that they could misinterpret other errors as ID conflicts and needlessly retry in those cases. This change fixes the logic to check for the HTTP 409 Conflict status code and retry only when creating a tunnel and not when updating an existing tunnel.
The other language SDKs use the older v1 API that doesn't require the client to generate a tunnel ID when creating a tunnel, so they do not have this issue.