Skip to content

Fix Worker Registry and Add Documentation Notes #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nytian merged 1 commit into from
Nov 6, 2025
+6 −13
Merged

Fix Worker Registry and Add Documentation Notes #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Client/Core/DependencyInjection/DefaultDurableTaskClientBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ public DurableTaskClient Build(IServiceProvider serviceProvider)
+ " 'UseBuildTarget(Type target)'. An example of a valid client is '.UseGrpc()'.");
}

// Note: Modifying any logic in this section could introduce breaking changes.
// Do not alter the input parameter.
return (DurableTaskClient)ActivatorUtilities.CreateInstance(serviceProvider, this.buildTarget, this.Name);
}

Expand Down
17 changes: 4 additions & 13 deletions src/Worker/Core/DependencyInjection/DefaultDurableTaskWorkerBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,18 +55,9 @@ public IHostedService Build(IServiceProvider serviceProvider)

DurableTaskRegistry registry = serviceProvider.GetOptions<DurableTaskRegistry>(this.Name);

// Get the IExceptionPropertiesProvider from DI if registered
IExceptionPropertiesProvider? exceptionPropertiesProvider = serviceProvider.GetService<IExceptionPropertiesProvider>();

if (exceptionPropertiesProvider != null)
{
return (IHostedService)ActivatorUtilities.CreateInstance(
serviceProvider, this.buildTarget, this.Name, registry.BuildFactory(), exceptionPropertiesProvider);
}
else
{
return (IHostedService)ActivatorUtilities.CreateInstance(
serviceProvider, this.buildTarget, this.Name, registry.BuildFactory());
}
// Note: Modifying any logic in this section could introduce breaking changes.
// Do not alter the input parameter.
return (IHostedService)ActivatorUtilities.CreateInstance(
serviceProvider, this.buildTarget, this.Name, registry.BuildFactory());
}
}
Loading