Introduce custom copilot review instructions by halspang · Pull Request #503 · microsoft/durabletask-dotnet

halspang · 2025-11-13T23:23:40Z

No description provided.

Signed-off-by: Hal Spang <halspang@microsoft.com>

Copilot

Pull Request Overview

This PR introduces a custom GitHub Copilot instructions file to standardize code contribution guidelines for both C# and Python code in a repository that provides a framework for building AI agents.

Establishes general C# code guidelines including copyright notices, XML documentation requirements, and breaking change policies
Defines detailed C# sample code guidelines covering project structure, documentation, coding patterns, and configuration management
Specifies C# unit test guidelines including test structure, mocking practices, and code quality standards

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Hal Spang <halspang@microsoft.com>

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Hal Spang <halspang@microsoft.com>

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Hal Spang <halspang@microsoft.com>

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Hal Spang <halspang@microsoft.com>

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Hal Spang <halspang@microsoft.com>

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Hal Spang <halspang@microsoft.com>

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Hal Spang <halspang@microsoft.com>

Introduce custom copilot review instructions

5c29f4b

Signed-off-by: Hal Spang <halspang@microsoft.com>

Copilot AI review requested due to automatic review settings November 13, 2025 23:23

Copilot started reviewing on behalf of halspang November 13, 2025 23:24 View session

Copilot finished reviewing on behalf of halspang November 13, 2025 23:25

Copilot AI reviewed Nov 13, 2025

View reviewed changes

Grammatical fixes

15c3763

Signed-off-by: Hal Spang <halspang@microsoft.com>

halspang requested a review from Copilot November 13, 2025 23:37

Copilot started reviewing on behalf of halspang November 13, 2025 23:38 View session

Copilot finished reviewing on behalf of halspang November 13, 2025 23:39

Copilot AI reviewed Nov 13, 2025

View reviewed changes

Comment thread .github/copilot-instructions.md Outdated

Comment thread .github/copilot-instructions.md Outdated

Comment thread .github/copilot-instructions.md Outdated

Align async and sealed class recommendations

d274d06

Signed-off-by: Hal Spang <halspang@microsoft.com>

halspang requested a review from Copilot November 13, 2025 23:46

Copilot started reviewing on behalf of halspang November 13, 2025 23:46 View session

Copilot finished reviewing on behalf of halspang November 13, 2025 23:48

Copilot AI reviewed Nov 13, 2025

View reviewed changes

Comment thread .github/copilot-instructions.md Outdated

Comment thread .github/copilot-instructions.md Outdated

Comment thread .github/copilot-instructions.md Outdated

Fix the copyright notice

1b4361a

Signed-off-by: Hal Spang <halspang@microsoft.com>

halspang requested a review from Copilot November 13, 2025 23:53

Copilot started reviewing on behalf of halspang November 13, 2025 23:53 View session

Copilot finished reviewing on behalf of halspang November 13, 2025 23:54

Copilot AI reviewed Nov 13, 2025

View reviewed changes

Comment thread .github/copilot-instructions.md Outdated

More grammar fixes

dc8b787

Signed-off-by: Hal Spang <halspang@microsoft.com>

halspang requested a review from Copilot November 13, 2025 23:56

Copilot started reviewing on behalf of halspang November 13, 2025 23:56 View session

Copilot finished reviewing on behalf of halspang November 13, 2025 23:57

Copilot AI reviewed Nov 13, 2025

View reviewed changes

Comment thread .github/copilot-instructions.md Outdated

Comment thread .github/copilot-instructions.md Outdated

Comment thread .github/copilot-instructions.md Outdated

Comment thread .github/copilot-instructions.md Outdated

Move some guidelines to base C# section

f57c4bd

Signed-off-by: Hal Spang <halspang@microsoft.com>

halspang requested a review from Copilot November 14, 2025 00:05

Copilot started reviewing on behalf of halspang November 14, 2025 00:05 View session

Copilot finished reviewing on behalf of halspang November 14, 2025 00:06

Copilot AI reviewed Nov 14, 2025

View reviewed changes

Comment thread .github/copilot-instructions.md Outdated

The grammar train continues

48ada0e

Signed-off-by: Hal Spang <halspang@microsoft.com>

halspang requested a review from Copilot November 14, 2025 00:09

Copilot started reviewing on behalf of halspang November 14, 2025 00:13 View session

Copilot finished reviewing on behalf of halspang November 14, 2025 00:14

Copilot AI reviewed Nov 14, 2025

View reviewed changes

cgillum reviewed Nov 14, 2025

View reviewed changes

Comment thread .github/copilot-instructions.md Outdated

Comment thread .github/copilot-instructions.md Outdated

Comment thread .github/copilot-instructions.md Outdated

Update purpose and clarify requirements

ae66a0d

Signed-off-by: Hal Spang <halspang@microsoft.com>

cgillum approved these changes Nov 14, 2025

View reviewed changes

halspang merged commit a4606ed into microsoft:main Nov 14, 2025
3 checks passed

dependabot Bot mentioned this pull request Dec 8, 2025

[nuget][Find]- Bump Microsoft.DurableTask.Client from 1.17.1 to 1.18.0 DFE-Digital/single-unique-identifier#247

Closed

dependabot Bot mentioned this pull request Dec 22, 2025

[nuget][Find]- Bump Microsoft.DurableTask.Client from 1.17.1 to 1.18.1 DFE-Digital/single-unique-identifier#328

Closed

dependabot Bot mentioned this pull request Jan 26, 2026

[nuget][Find]- Bump Microsoft.DurableTask.Client from 1.17.1 to 1.19.1 DFE-Digital/single-unique-identifier#368

Closed

dependabot Bot mentioned this pull request Feb 3, 2026

[nuget][Find]- Bump Microsoft.DurableTask.Client from 1.17.1 to 1.20.1 DFE-Digital/single-unique-identifier#391

Closed

Uh oh!

Conversation

halspang commented Nov 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants