Update project to support .NET 6.0 alongside .NET 8.0 and .NET 10 by torosent · Pull Request #512 · microsoft/durabletask-dotnet

torosent · 2025-11-24T05:18:26Z

This pull request updates the supported .NET target frameworks across both the SDK and test projects to focus on .NET 10.0, while expanding SDK support to include .NET 6.0. Additionally, it updates the build pipeline to install the .NET 8 SDK and refactors source generator test utilities to use .NET 10.0 reference assemblies. These changes streamline test coverage and ensure compatibility with the latest .NET versions.

SDK and Worker/Client Project Framework Updates

Expanded target frameworks in Client.AzureManaged.csproj, Worker.AzureManaged.csproj, and ScheduledTasks.csproj to include net6.0, net8.0, and net10.0 for broader SDK compatibility. [1] [2] [3]

Test Project Framework Consolidation

Changed all test project files to target only net10.0, removing support for older frameworks and simplifying test execution. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]

Build Pipeline Improvements

Added a build step to install the .NET 8 SDK in the Azure Pipeline template to support builds that require this version.

Source Generator Test Refactoring

Updated CSharpSourceGeneratorVerifier.cs to use .NET 10.0 reference assemblies and refactored the reference assembly creation logic for future extensibility. [1] [2] [3]

General Codebase Maintenance

Minor code cleanup and import adjustments in utility files to support new framework targets.

…d adjust build configurations

Copilot

Pull request overview

This PR adds .NET 6.0 support to the Durable Task SDK alongside the existing .NET 8.0 and .NET 10.0 targets. This enhances compatibility for projects that require .NET 6.0 LTS support while maintaining support for newer framework versions.

Key Changes

Updated 8 project files (5 test projects and 3 source projects) to include net6.0 in their TargetFrameworks
Enhanced generator test infrastructure with conditional compilation to select appropriate reference assemblies based on the target framework
Updated build configuration to install .NET 8 SDK and improve multi-targeting output path handling

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/Worker/Grpc.Tests/Worker.Grpc.Tests.csproj	Added net6.0 to TargetFrameworks alongside net8.0, net10.0, and net48
test/Worker/AzureManaged.Tests/Worker.AzureManaged.Tests.csproj	Added net6.0 to TargetFrameworks alongside net8.0 and net10.0
test/ScheduledTasks.Tests/ScheduledTasks.Tests.csproj	Added net6.0 to TargetFrameworks alongside net8.0 and net10.0
test/Generators.Tests/Utils/CSharpSourceGeneratorVerifier.cs	Refactored to use conditional compilation for framework-specific reference assemblies, added support for net6.0 with Microsoft.NETCore.App.Ref 6.0.36
test/Generators.Tests/Generators.Tests.csproj	Added net6.0 to TargetFrameworks alongside net8.0 and net10.0
test/Client/AzureManaged.Tests/Client.AzureManaged.Tests.csproj	Added net6.0 to TargetFrameworks alongside net8.0 and net10.0
src/Worker/AzureManaged/Worker.AzureManaged.csproj	Added net6.0 to TargetFrameworks alongside net8.0 and net10.0
src/ScheduledTasks/ScheduledTasks.csproj	Added net6.0 to TargetFrameworks alongside net8.0 and net10.0
src/Client/AzureManaged/Client.AzureManaged.csproj	Added net6.0 to TargetFrameworks alongside net8.0 and net10.0
eng/templates/build.yml	Added .NET 8 SDK installation step to support multi-targeting build scenarios
Directory.Build.props	Enhanced output path configuration to include framework-specific subdirectories, preventing build conflicts in multi-targeted projects

…ort for multiple target frameworks

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 16 comments.

Copilot · 2025-11-24T21:09:44Z


  <PropertyGroup>
-    <TargetFrameworks>net8.0;net10.0;net48</TargetFrameworks>
+    <TargetFramework>net10.0</TargetFramework>


This change contradicts the PR's stated goal. The PR description indicates adding .NET 6.0 support, but this change removes multi-targeting and only targets .NET 10.0, effectively removing support for .NET 8.0, .NET 6.0, and .NET Framework 4.8.

To align with the PR's goal, this should be:

<TargetFrameworks>net6.0;net8.0;net10.0;net48</TargetFrameworks>

This ensures the tests run against all supported frameworks, including the newly added .NET 6.0.

Suggested change

<TargetFramework>net10.0</TargetFramework>

<TargetFrameworks>net6.0;net8.0;net10.0;net48</TargetFrameworks>

Copilot · 2025-11-24T21:09:45Z


  <PropertyGroup>
-    <TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>
+    <TargetFramework>net10.0</TargetFramework>


This change contradicts the PR's stated goal. The PR description indicates adding .NET 6.0 support, but this change removes multi-targeting and only targets .NET 10.0, effectively removing test coverage for .NET 6.0 and .NET 8.0.

To align with the PR's goal, this should remain:

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

This ensures the tests run against all supported frameworks.

Suggested change

<TargetFramework>net10.0</TargetFramework>

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Copilot · 2025-11-24T21:09:45Z


  <PropertyGroup>
-    <TargetFrameworks>net6.0;net8.0;net10.0;netstandard2.0</TargetFrameworks>
+    <TargetFramework>net10.0</TargetFramework>


This change removes multi-targeting support from the test helpers project, which will impact all tests that depend on it. The original configuration supported .NET 6.0, .NET 8.0, .NET 10.0, and .NET Standard 2.0.

To align with the PR's goal and maintain compatibility across all frameworks, this should remain:

<TargetFrameworks>net6.0;net8.0;net10.0;netstandard2.0</TargetFrameworks>

Removing multi-targeting from a shared test helper project will force all dependent test projects to use only .NET 10.0, reducing test coverage.

Suggested change

<TargetFramework>net10.0</TargetFramework>

<TargetFrameworks>net6.0;net8.0;net10.0;netstandard2.0</TargetFrameworks>

Copilot · 2025-11-24T21:09:45Z


  <PropertyGroup>
-    <TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>
+    <TargetFramework>net10.0</TargetFramework>


This change contradicts the PR's stated goal and removes test coverage. The source project src/InProcessTestHost/InProcessTestHost.csproj targets net6.0;net8.0;net10.0, but this test project now only targets .NET 10.0.

To align with the PR's goal and ensure comprehensive test coverage, this should remain:

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Suggested change

<TargetFramework>net10.0</TargetFramework>

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Copilot · 2025-11-24T21:09:46Z


  <PropertyGroup>
-    <TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>
+    <TargetFramework>net10.0</TargetFramework>


This change contradicts the PR's stated goal and removes test coverage for .NET 6.0 and .NET 8.0.

To align with the PR's goal and ensure comprehensive test coverage, this should remain:

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Suggested change

<TargetFramework>net10.0</TargetFramework>

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Copilot · 2025-11-24T21:09:48Z


  <PropertyGroup>
-    <TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>
+    <TargetFramework>net10.0</TargetFramework>


This change contradicts the PR's stated goal and removes test coverage for .NET 6.0 and .NET 8.0.

To align with the PR's goal and ensure comprehensive test coverage, this should remain:

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Suggested change

<TargetFramework>net10.0</TargetFramework>

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Copilot · 2025-11-24T21:09:48Z


  <PropertyGroup>
-    <TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>
+    <TargetFramework>net10.0</TargetFramework>


This change contradicts the PR's stated goal and removes test coverage for .NET 6.0 and .NET 8.0.

To align with the PR's goal and ensure comprehensive test coverage, this should remain:

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Suggested change

<TargetFramework>net10.0</TargetFramework>

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Copilot · 2025-11-24T21:09:49Z


  <PropertyGroup>
-    <TargetFrameworks>net8.0;net10.0</TargetFrameworks>
+    <TargetFramework>net10.0</TargetFramework>


This change contradicts the PR's stated goal and removes test coverage. The original configuration tested against both .NET 8.0 and .NET 10.0.

To align with the PR's goal and ensure comprehensive test coverage, this should be:

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Suggested change

<TargetFramework>net10.0</TargetFramework>

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Copilot · 2025-11-24T21:09:49Z


  <PropertyGroup>
-    <TargetFrameworks>net6.0;net8.0;net10.0;net48</TargetFrameworks>
+    <TargetFramework>net10.0</TargetFramework>


This change contradicts the PR's stated goal and removes test coverage. The original configuration tested against .NET 6.0, .NET 8.0, .NET 10.0, and .NET Framework 4.8, but now only targets .NET 10.0.

To align with the PR's goal and ensure comprehensive test coverage, this should remain:

<TargetFrameworks>net6.0;net8.0;net10.0;net48</TargetFrameworks>

Suggested change

<TargetFramework>net10.0</TargetFramework>

<TargetFrameworks>net6.0;net8.0;net10.0;net48</TargetFrameworks>

Copilot · 2025-11-24T21:09:49Z


  <PropertyGroup>
-    <TargetFrameworks>net8.0;net10.0</TargetFrameworks>
+    <TargetFramework>net10.0</TargetFramework>


This change contradicts the PR's stated goal and removes test coverage. The source project src/Client/AzureManaged/Client.AzureManaged.csproj is being updated to target net6.0;net8.0;net10.0, but this test project now only targets .NET 10.0.

To align with the PR's goal and ensure comprehensive test coverage, this should be:

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Suggested change

<TargetFramework>net10.0</TargetFramework>

<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Update project to support .NET 6.0 alongside .NET 8.0 and .NET 10, an…

53f3c96

…d adjust build configurations

Copilot AI review requested due to automatic review settings November 24, 2025 05:18

Copilot started reviewing on behalf of torosent November 24, 2025 05:18 View session

torosent closed this Nov 24, 2025

Copilot finished reviewing on behalf of torosent November 24, 2025 05:21

Copilot AI reviewed Nov 24, 2025

View reviewed changes

torosent reopened this Nov 24, 2025

torosent added 2 commits November 24, 2025 12:51

Update tests

9f655e3

Refactor project files to target .NET 10.0 exclusively, removing supp…

b3e660c

…ort for multiple target frameworks

Copilot AI review requested due to automatic review settings November 24, 2025 21:03

Copilot started reviewing on behalf of torosent November 24, 2025 21:03 View session

Copilot finished reviewing on behalf of torosent November 24, 2025 21:07

Copilot AI reviewed Nov 24, 2025

View reviewed changes

halspang approved these changes Nov 24, 2025

View reviewed changes

torosent merged commit 65c9e1a into main Nov 24, 2025
10 checks passed

torosent deleted the torosent/update-net-versions branch November 24, 2025 21:57

dependabot Bot mentioned this pull request Dec 8, 2025

[nuget][Find]- Bump Microsoft.DurableTask.Client from 1.17.1 to 1.18.0 DFE-Digital/single-unique-identifier#247

Closed

dependabot Bot mentioned this pull request Dec 22, 2025

[nuget][Find]- Bump Microsoft.DurableTask.Client from 1.17.1 to 1.18.1 DFE-Digital/single-unique-identifier#328

Closed

dependabot Bot mentioned this pull request Jan 26, 2026

[nuget][Find]- Bump Microsoft.DurableTask.Client from 1.17.1 to 1.19.1 DFE-Digital/single-unique-identifier#368

Closed

dependabot Bot mentioned this pull request Feb 3, 2026

[nuget][Find]- Bump Microsoft.DurableTask.Client from 1.17.1 to 1.20.1 DFE-Digital/single-unique-identifier#391

Closed

	<TargetFramework>net10.0</TargetFramework>
	<TargetFrameworks>net6.0;net8.0;net10.0;net48</TargetFrameworks>

	<TargetFramework>net10.0</TargetFramework>
	<TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks>

Uh oh!

Conversation

torosent commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

torosent commented Nov 24, 2025 •

edited

Loading