Add Tags to CreateSubOrchestrationAction#558
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for serializing tags on suborchestration actions by adding a tags field to the CreateSubOrchestrationAction protobuf message and implementing the serialization logic in ProtoUtils.cs. The implementation follows the same pattern used for ScheduleTaskAction tags serialization.
Key Changes:
- Added
map<string, string> tagsfield to CreateSubOrchestrationAction proto message - Implemented tags serialization in ProtoUtils.cs for CreateSubOrchestrationAction
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Grpc/orchestrator_service.proto | Added tags field to CreateSubOrchestrationAction message; also contains unrelated changes to OrchestratorResponse (isPartial and chunkIndex fields) |
| src/Shared/Grpc/ProtoUtils.cs | Added tags serialization logic for CreateSubOrchestrationAction, mirroring the existing pattern for ScheduleTaskAction |
YunchuWang
self-requested a review
December 12, 2025 16:15
YunchuWang
approved these changes
Dec 12, 2025
YunchuWang
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR serializes the tags field and adds it to the CreateSubOrchestrationAction proto to enable adding user tags to suborchestrations.
Resolves #399