-
Notifications
You must be signed in to change notification settings - Fork 632
Remove the majority of nightly features #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| license = "MIT" | ||
| repository = "https://github.com/microsoft/edit" | ||
| rust-version = "1.88" | ||
| rust-version = "1.93" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW this is the latest stable version which was released earlier this month. (We could support older versions if we add more shims.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW this is the latest stable version which was released earlier this month. (We could support older versions if we add more shims.)
@lhecker Just curious, why support older versions of Rust? Why shims? Rust always works on all platforms. I think it's more correct to always prefer the Rust std and keep the code concise.
| // Licensed under the MIT License. | ||
|
|
||
| use std::hint::cold_path; | ||
| use stdext::cold_path; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR for stabilizing cold_path was just merged by the Rust team hours ago:
rust-lang/rust#151576
Another PR for the cold_path release notes was just opened with the 1.95.0 milestone:
rust-lang/rust#152251
Rust version 1.95.0 is planned to be stable on April 16, 2026:
https://releases.rs/docs/1.95.0/
| license = "MIT" | ||
| repository = "https://github.com/microsoft/edit" | ||
| rust-version = "1.88" | ||
| rust-version = "1.93" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW this is the latest stable version which was released earlier this month. (We could support older versions if we add more shims.)
@lhecker Just curious, why support older versions of Rust? Why shims? Rust always works on all platforms. I think it's more correct to always prefer the Rust std and keep the code concise.
This removes:
Closes #44