fix: render SVG shapes and text inside the repeat directive#7640
Open
AKnassa wants to merge 1 commit into
Open
fix: render SVG shapes and text inside the repeat directive#7640AKnassa wants to merge 1 commit into
AKnassa wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds an
svgtemplate helper so SVG content written inside arepeatdirective actually renders in the browser.Why
SVG elements such as
<text>and<circle>placed inside arepeatcame out invisible. The browser silently ignored them because they were created in the wrong XML namespace.What changed
svgtagged template helper alongside the existinghtmlonesvgnow create elements in the SVG namespacehtmltemplates are unchangedHow to see it
Run the fast-element Playwright suite. 49 tests cover this file, including 5 new ones for the
svghelper.Closes #6599