chore: enable noImplicitAny and strictPropertyInitialization for fast-router#7645
Open
AKnassa wants to merge 1 commit into
Open
chore: enable noImplicitAny and strictPropertyInitialization for fast-router#7645AKnassa wants to merge 1 commit into
AKnassa wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Turns on two stricter TypeScript checks for the
fast-routerpackage.Why
fast-routerwas opting out of two safety checks the rest of the repo already uses. Turning them on catches a whole class of mistakes at build time instead of at runtime.What changed
packages/fast-router/tsconfig.json, so the package now inherits the strict settings from the root configHow to see it
The typecheck itself is the test. It passes with zero errors, and all 10,917 router tests still pass.
Closes #5341