fix(glob): actually sort results by modification time#34
Open
T0mSIlver wants to merge 1 commit into
Open
Conversation
glob.md promises 'matching file paths sorted by modification time', but the rg --files invocation passed no --sort flag, so ripgrep returned results in arbitrary traversal order (default --sort=none). Add --sort modified so the output matches the documented contract, and add a test that stamps mtimes and asserts the resulting order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
glob.mdstates: "Returns matching file paths sorted by modification time." But the command wasrg --files <dir> --glob <pattern>with no--sortflag. ripgrep's default is--sort=none, so results came back in arbitrary traversal order — the documented ordering was never applied.Fix
Pass
--sort modifiedso results are genuinely ordered by modification time (oldest → newest), matching the prompt's contract. Addstests/test_glob_sort.pywhich stamps three files with known mtimes and asserts the returned order.Paper reference
Confirmed by the paper: Glob "returns matching file paths sorted by modification time", so the sort is intentional and the missing
--sortflag was the bug. — FastContext paper (arXiv:2606.14066), Appendix E "FastContext Explorer: Tool Schemas", p. 19