fix(grep): don't force -C 3 context on every content search#35
Open
T0mSIlver wants to merge 1 commit into
Open
fix(grep): don't force -C 3 context on every content search#35T0mSIlver wants to merge 1 commit into
T0mSIlver wants to merge 1 commit into
Conversation
context defaulted to 3 (params.get('-C', 3)), so run_rg always appended
'-C 3' in content mode — injecting surrounding context even when the
model requested none or only -A/-B. The schema says -C is 'ignored
otherwise' and documents no default. Only apply context when the model
actually provides -C, and add a test covering both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
context = params.get("-C", 3)gave-Ca hidden default of 3. Sincerun_rgappends-Cwhenevercontext is not None, every content-mode search carried 3 lines of surrounding context — including before-context — even when the model passed no context flags or only-A/-B. This is undocumented; the schema describes-Cas optional and "ignored otherwise".Fix
Default
-CtoNoneso context is applied only when the model explicitly requests it. Addstests/test_grep_context.pyasserting no context appears by default and that-C=1includes neighbors.Paper reference
Confirmed by the paper:
-B/-A/-Care "Lines of context before, after, or around each match when output_mode is content" — optional context flags with no default — so forcing-C 3contradicted the spec. — FastContext paper (arXiv:2606.14066), Appendix E "FastContext Explorer: Tool Schemas", p. 19