docs(grep): fix malformed glob examples#37
Open
T0mSIlver wants to merge 1 commit into
Open
Conversation
The example globs in grep.md were written as '.js' and '**/.tsx', which match literal dotfiles rather than files by extension. Correct them to '*.js' and '**/*.tsx' so the model copies a working pattern, and add a test asserting the examples are valid and that '*.js' matches by extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
grep.mdgives glob examples as".js"and"**/.tsx". Those match literal dotfiles (a file named.js, or.tsxfiles in a subdir), not files by extension — the opposite of what the line intends. The model copies these patterns.Fix
Correct to
"*.js"and"**/*.tsx", consistent with the working examples in theglobparameter's own schema description. Addstests/test_grep_glob_examples.pyasserting the examples are valid and that the documented*.jspattern matches by extension.Paper reference
Supported by the paper, whose glob examples are all extension globs (e.g.
"*.js","*.{ts,tsx}","**/*.js","src/**/*.ts"), consistent with the corrected forms here. — FastContext paper (arXiv:2606.14066), Appendix E "FastContext Explorer: Tool Schemas", p. 19