[Dialog] Add DynamicDependency to prevent trimming#5009
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves trimming/linker compatibility for the dialog system by ensuring the RenderFragmentDialog component’s public constructors are preserved during publish-time optimization, addressing the CtorNotLocated runtime failure reported in #5005.
Changes:
- Added a code-behind partial class for
RenderFragmentDialogannotated withDynamicDependencyto preserve public constructors under trimming.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.2%
|
dvoituron
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a change to enhance compatibility with trimming tools by adding DynamicDependency attributes to a dialog component. This changes ensure that the public constructors of the component is preserved during trimming.
Enhancements for trimming compatibility:
RenderFragmentDialogwith aDynamicDependencyattribute to ensure its public constructors are preserved during build optimization. (src/Core/Components/Dialog/ContentComponents/RenderFragmentDialog.razor.cs)Fix #5005