Skip to content

Fix FluentTimePicker dropdown auto-scroll for active values#5010

Closed
vnbaaij with Copilot wants to merge 2 commits into
dev-v5from
copilot/dev-v5-add-auto-scroll-to-active-item
Closed

Fix FluentTimePicker dropdown auto-scroll for active values#5010
vnbaaij with Copilot wants to merge 2 commits into
dev-v5from
copilot/dev-v5-add-auto-scroll-to-active-item

Conversation

Copilot AI commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Pull Request

📖 Description

FluentTimePicker’s Fluent UI dropdown did not surface the active selection clearly when values were edited or reopened. The popup could stay at its default offset, leaving the matched option at the bottom of the visible list and forcing unnecessary manual scrolling.

This change adds a focused scroll hook for the Fluent UI TimePicker dropdown so the active or selected time is brought into view near the top of the popup when the value changes or the dropdown is opened/focused. The change is isolated to the Fluent UI render path and includes cleanup when the component is disposed.

🎫 Issues

  • Addresses the FluentTimePicker auto-scroll behavior requested for the Fluent UI dropdown experience.

👩‍💻 Reviewer Notes

  • The change is concentrated in the TimePicker’s JS interop path and disposal behavior; the native render path remains unchanged.
  • The main thing to review is that the new scroll logic is triggered at the right times and is cleaned up safely.

📑 Test Plan

  • Added unit coverage for the Fluent UI TimePicker’s JS initialization and disposal flow.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

MCP Server

  • I have added or updated MCP Server tools/prompts/resources
  • I have added Unit Tests for my MCP Server changes

⏭ Next Steps

  • None.

Copilot AI requested review from Copilot and removed request for Copilot July 10, 2026 06:49
Copilot AI linked an issue Jul 10, 2026 that may be closed by this pull request
Copilot AI requested review from Copilot and removed request for Copilot July 10, 2026 07:05
Copilot AI changed the title [WIP] Add auto-scroll feature to active item in FluentTimePicker Fix FluentTimePicker dropdown auto-scroll for active values Jul 10, 2026
Copilot AI requested a review from vnbaaij July 10, 2026 07:06
@dvoituron

Copy link
Copy Markdown
Collaborator

Too complex and incorrect. Closing to work on it later.

@dvoituron dvoituron closed this Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dev-v5] add auto-scroll to active item in FluentTimePicker

3 participants