[dev-v5][Text] Repurpose As parameter#5017
Open
vnbaaij wants to merge 3 commits into
Open
Conversation
… wrapper - Repurpose the `As` parameter to produce semantic HML in the renderd output - Update tests and verified files
vnbaaij
changed the title
As parameter
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.9%
Microsoft.FluentUI.AspNetCore.Components.Charts - 100%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the FluentText Blazor component to stop emitting the (now unsupported) as attribute on the underlying Fluent UI web component, and repurposes the As parameter to generate semantic HTML by wrapping ChildContent in the selected tag. It also updates documentation, demo examples, and a large set of snapshot/verified test outputs impacted by the rendering change.
Changes:
- Remove the
asattribute from the<fluent-text>wrapper and makeAsoptional (TextTag?). - When
Asis provided, render semantic HTML via an inner wrapper element (usingAddTag). - Update unit tests and many
.verified.razor.htmlfiles to reflect the new rendered output.
Reviewed changes
Copilot reviewed 78 out of 78 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Core/Components/Text/FluentTextTests.razor | Updates markup assertions for removed as attr and new semantic wrapper behavior. |
| tests/Core/Components/Text/FluentTextTests.FluentText_Underline.verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Text/FluentTextTests.FluentText_StyleAttribute.verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Text/FluentTextTests.FluentText_Strikethrough.verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Text/FluentTextTests.FluentText_Nowrap.verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Text/FluentTextTests.FluentText_Italic.verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Text/FluentTextTests.FluentText_IdAttribute-id-value.verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Text/FluentTextTests.FluentText_IdAttribute-[space].verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Text/FluentTextTests.FluentText_IdAttribute-[null].verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Text/FluentTextTests.FluentText_IdAttribute-[empty].verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Text/FluentTextTests.FluentText_Default.verified.razor.html | Snapshot update for default rendering (no as). |
| tests/Core/Components/Text/FluentTextTests.FluentText_ClassAttribute.verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Text/FluentTextTests.FluentText_Block.verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Text/FluentTextTests.FluentText_AdditionalAttributes.verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Text/FluentTextTests.FluentText_AdditionalAttribute.verified.razor.html | Snapshot update for removed as attr. |
| tests/Core/Components/Switch/FluentSwitchTests.FluentSwitch_Default.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Switch/FluentSwitchTests.FluentCheckbox_Required.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Switch/FluentSwitchTests.FluentCheckbox_ReadOnly.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Switch/FluentSwitchTests.FluentCheckbox_LabelTemplate.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Slider/FluentSliderTests.FluentSlider_Slot_Thumb.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Slider/FluentSliderTests.FluentSlider_Default.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Radio/FluentRadioTests.FluentRadio_LabelWidth.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Radio/FluentRadioTests.FluentRadio_LabelTemplate.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Radio/FluentRadioTests.FluentRadio_Label.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Radio/FluentRadioTests.FluentRadio_HorizontalOrientation.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Radio/FluentRadioTests.FluentRadio_Default.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Radio/FluentRadioGroupTests.FluentRadioGroup_WithChildContent.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Radio/FluentRadioGroupTests.FluentRadioGroup_Items.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Radio/FluentRadioGroupTests.FluentRadioGroup_Default.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentSelectTests.FluentSelect_Width_And_Height.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentSelectTests.FluentSelect_OptionFunctions.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentSelectTests.FluentSelect_Manual.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentSelectTests.FluentSelect_Label.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentSelectTests.FluentSelect_GetOptionValue_DefaultWhenTypesAreDifferent.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentSelectTests.FluentSelect_Enum.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentSelectTests.FluentSelect_Default.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentListboxTests.FluentListbox_OptionFunctions.verified.razor.html | Snapshot update (event attr name + message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentListboxTests.FluentListbox_Manual.verified.razor.html | Snapshot update (event attr name + message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentListboxTests.FluentListbox_Label.verified.razor.html | Snapshot update (event attr name + message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentListboxTests.FluentListbox_GetOptionValue_DefaultWhenTypesAreDifferent.verified.razor.html | Snapshot update (event attr name + message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentListboxTests.FluentListbox_Enum.verified.razor.html | Snapshot update (event attr name + message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentListboxTests.FluentListbox_Default.verified.razor.html | Snapshot update (event attr name + message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentComboboxTests.FluentCombobox_OptionFunctions.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentComboboxTests.FluentCombobox_Manual.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentComboboxTests.FluentCombobox_Label.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentComboboxTests.FluentCombobox_Enum.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentComboboxTests.FluentCombobox_Default.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentAutocompleteTests.FluentAutocomplete_Label.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/List/FluentAutocompleteTests.FluentAutocomplete_Default_Items.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_Size-small.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_Size-medium.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_Size-large.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_Size-99.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_Size-[empty].verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_MessageState-warning.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_MessageState-success.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_MessageState-error.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_MessageState-99.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_MessageState-[empty].verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_MessageIcon.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_DefaultTemplate.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Field/FluentFieldTests.FluentField_Default.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Checkbox/FluentCheckboxTests.FluentCheckbox_Size-medium.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Checkbox/FluentCheckboxTests.FluentCheckbox_Size-large.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Checkbox/FluentCheckboxTests.FluentCheckbox_Size-999.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Checkbox/FluentCheckboxTests.FluentCheckbox_Size-[empty].verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Checkbox/FluentCheckboxTests.FluentCheckbox_ShowIndeterminate.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Checkbox/FluentCheckboxTests.FluentCheckbox_Shape-square.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Checkbox/FluentCheckboxTests.FluentCheckbox_Shape-circular.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Checkbox/FluentCheckboxTests.FluentCheckbox_Shape-999.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Checkbox/FluentCheckboxTests.FluentCheckbox_Shape-[empty].verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Checkbox/FluentCheckboxTests.FluentCheckbox_LabelTemplate.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Checkbox/FluentCheckboxTests.FluentCheckbox_EnableThreeState.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| tests/Core/Components/Checkbox/FluentCheckboxTests.FluentCheckbox_Default.verified.razor.html | Snapshot update (message <fluent-text> no longer has as). |
| src/Core/Components/Text/FluentText.razor.cs | Makes As nullable and updates component API surface/docs. |
| src/Core/Components/Text/FluentText.razor | Removes as attribute; wraps ChildContent via AddTag when As is set. |
| examples/Demo/FluentUI.Demo.Client/Documentation/Components/Text/FluentText.md | Updates Text docs to explain new default rendering and As behavior. |
| examples/Demo/FluentUI.Demo.Client/Documentation/Components/Text/Examples/TextDefault.razor | Updates demo snippet to show default output and optional semantic wrapping via As. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asattribute from the web component wrapperAsparameter to produce semantic HML in the rendered outputPR files are actually only 4 files (doc, example and component files). Rest are all tests that needed change and/or new verified files