ci: add root level tasks to lage #4030
Conversation
|
apps/win32-81/package.json
Outdated
| "react-test-renderer": "19.1.0", | ||
| "rimraf": "catalog:" | ||
| }, | ||
| "peerDependencies": { |
There was a problem hiding this comment.
I think these should be dependencies rather than peer dependencies as this is an endpoint package. If these are peer dependencies these packages should be added as devDependencies.
There was a problem hiding this comment.
I believe this is the output of lint-package-fix. I'll see what happened
There was a problem hiding this comment.
Peer dependencies were enforced transitively all the way down to app packages. I updated the lint rule to check if the kitConfig is "app" and skip enforcing the lint in that case. I also marked tester-win32 and tester-win32-81 as private because https://www.npmjs.com/package/@fluentui-react-native/tester-win32?activeTab=versions has basically zero downloads. That has the side effect of also moving their versions to 0.1.0
Description of changes
We have some tasks that run per pacakge (
build,lint, etc), and some that run at the workspace level (lint-lockfile,formatbecause its way faster that way, etc. We didn't clearly delineate these two types of tasks and Lage would get confused when I tried to. So, I asked Claude to do it.While here, also bump Yarn to 4.13.0 because i noticed that updated :)
Claudes summary of the changes below
Verification
CI should pass
Pull request checklist
This PR has considered (when applicable):