Skip to content

ci: fix more publishing issues#4032

Merged
Saadnajmi merged 8 commits intomicrosoft:mainfrom
Saadnajmi:more-fixes-2
Mar 2, 2026
Merged

ci: fix more publishing issues#4032
Saadnajmi merged 8 commits intomicrosoft:mainfrom
Saadnajmi:more-fixes-2

Conversation

@Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Mar 1, 2026

Description of changes

  1. My publish-worker scripts' JSDoc type signature was wrong. We can actually use typescript directly.. so let's do that.
  2. We had 2 packages that were marked private, but depended on public packages, and would then get bumped by changesets. I have a lint rule saying private packages stay 0.1.0, so the "Version Packages" PR would fail lint. I think the simplest fix is to either publish the package, add it to the changeset ingore, or delete it. In this case, it's safe to delete.
  3. While here, I noticed we run a full build before generating the PR. I think we don't need to do that.

Verification

CI should pass

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2026

⚠️ No Changeset found

Latest commit: 48fed96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Saadnajmi Saadnajmi changed the title ci: fix types of publish worker script ci: fix more publishing issues Mar 2, 2026
@Saadnajmi Saadnajmi merged commit 5e9ab58 into microsoft:main Mar 2, 2026
13 checks passed
@Saadnajmi Saadnajmi deleted the more-fixes-2 branch March 2, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants