chore(react-icons): migrate to ts 4.9.5#867
Draft
Hotell wants to merge 2 commits intomicrosoft:mainfrom
Draft
Conversation
Hotell
force-pushed
the
react-icons/tsc-bump/4-x
branch
from
49ffc37 to
3a8c2b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by microsoft/griffel#682
This is same issue we have in FUI and FAI -> because of this the only solution is to transpile to esm with griffel processing and re-transpile from esm js to commonjs:
ts[ESM] -> js[babel+griffel] -> js[ESM] -> ts[CJS] -> js[CJS]@layershifter can you help me understand if this can have breaking consequences for users using AOT with webpack griffel plugin if they don't enforce all fluent to resolve against ESM outputs ?