Relax requirements, workaround for weasyprint removing image rendering (due to removing cairo dep).#62
Open
rwightman wants to merge 2 commits intomicrosoft:mainfrom
Open
Relax requirements, workaround for weasyprint removing image rendering (due to removing cairo dep).#62rwightman wants to merge 2 commits intomicrosoft:mainfrom
rwightman wants to merge 2 commits intomicrosoft:mainfrom
Conversation
…e output via fitz (pymupdf) or pypdfium2
Author
|
@laserprec looks like you've moved on from MS, but might know who to ping there if there's any interest in keeping this project alive. Thanks |
Contributor
|
Hi @rwightman, thanks for your support of the repo and offer to help, and I apologize for this late response. Yes, I am no longer able to help merging PRs. I think @jgc128 and/or @amitgupte should be able to help here. |
|
Is this repository still maintained? #64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm planning to base a (partially) synthetic document datapipeline on generation capabilities in this lib. As is known from issues going back 2 years, in it's current state this library cannot be installed (too many out of date dependencies), and use of weasyprint is broken after they removed pdf/image rendering.
This PR
Tests for png/image output require a rethink.
I'd like to know if there'd be any intent on merging these changes. If I could be added as a maintainer? Otherwise I'll likely have to maintain a parallel fork w/ new pip package to be able to use in other projects.
Thanks!