codeql: do call apt-get update - #870
Merged
Merged
Conversation
As of b133d30 (github: simplify computation of the job's distro, 2025-01-10), the `apt-get update` call that is guarded by `$distro` in the `ci/install-dependencies.sh` script requires the `CI_JOB_IMAGE` variable to set correctly (which is used to initialize `distro` in the GitHub Actions-specific part at the top of `ci/lib.sh`). Let's do the same in the CodeQL workflow. Noticed-by: Derrick Stolee <stolee@gmail.com> Noticed-by: Tyrie Vella <tyrielv@gmail.com> Noticed-by: Matthew John Cheetham <mjcheetham@outlook.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
mjcheetham
approved these changes
Mar 26, 2026
dscho
enabled auto-merge
March 26, 2026 13:22
derrickstolee
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of b133d30 (github: simplify computation of the job's distro, 2025-01-10), the
apt-get updatecall that is guarded by$distroin theci/install-dependencies.shscript requires theCI_JOB_IMAGEvariable to set correctly (which is used to initializedistroin the GitHub Actions-specific part at the top ofci/lib.sh).Let's do the same in the CodeQL workflow.
/cc @derrickstolee @tyrielv @mjcheetham